Deprecated function: Creation of dynamic property

Hi @Belba, it will be a PHP 8.2 compatibility issue, Please review the patch.

@MukhtarM, thanks for the patch, this is working fine.

The same warning appears also in the files: \advagg\advagg_js_minify\jsqueeze.inc
\advagg\advagg_bundler\src\Asset\AdvaggCssCollectionGrouper.php

I add the following attribute, just before the class : #[\AllowDynamicProperties]
This takes the error message away, but i asume the approach from Mukthar is a better solution.

* Changed the accessibility to protected in AdvaggJsCollectionGrouper
* Added the same protected property in AdvaggCssCollectionGrouper

This warning was emitted on every run of `drush cr` (Drupal 10.1.1). Just applied the patch from #5 and it works fine.

LGTM

Installed patch #5 and the error went away

RTBC+1

I got many deprecation error of: Creation of dynamic property in jsminplus.inc JSNode::__set() when opening a webform admin page.
Not sure if anyone also see this.

PHP 8.2, Drupal 10.2.1

Currently downgrading to PHP 8.1 seems to fixed the issue.

Confirmed #11

I got several error message

Deprecated function: Creation of dynamic property JSNode::$expression is deprecated at JSNode->__set() (file /var/www/html/docroot/modules/contrib/advagg/advagg_js_minify/jsminplus.inc 1831 )

Drupal core 10.2.0

PHP 8.2.7

chetan 11 → made their first commit to this issue’s fork.

Please check the above MR.

In addition to the errors that patch #5 solves, this patch also solves the error in jsminplus.inc file.

Hi, great patch #17
D10.2.3 & php 8.2.13
Fixed the error :

Deprecated function : Creation of dynamic property Drupal\advagg_bundler\Asset\AdvaggCssCollectionGrouper::$config is deprecated dans Drupal\advagg_bundler\Asset\AdvaggCssCollectionGrouper->__construct()

RTBC+1

#17 removed the errors for me on D10.2.4, with no apparent problems.

Patch #17 resolved the issue for me as well. This should have been a commit to the existing issue fork though. Going to set this to RTBC as multiple people have tested it.

Adjusting meta data

It works for you AdvAgg Bundler?

Warning disappeared
D10.2.5, PHP 8.2.18
Thanks.

The patch #17 does not work with PHP 8.3.7.
Does anyone know how to solve the problem with PHP 8.3?

Patch #17 - Verified and tested it on a Drupal 10.2.7 and PHP 8.2.19
The patch works fine.

Thanks

Tested MR patch with PHP 8.3 and core 10.4.6 and works fine!

confirmed working.