πŸ‡«πŸ‡·France @vanessa.fayard

Account created on 13 December 2022, over 1 year ago
#

Recent comments

πŸ‡«πŸ‡·France vanessa.fayard

Patch update for D10 compatibility, from issue #3367901

Works on Drupal 10.2.7 - PHP8.2
Version : 1.0.2

πŸ‡«πŸ‡·France vanessa.fayard

Patch #17 - Verified and tested it on a Drupal 10.2.7 and PHP 8.2.19
The patch works fine.

Thanks

πŸ‡«πŸ‡·France vanessa.fayard

Hello,

Patches 1 and 2 successfully tested and validated.
Proposal 2 approved to enhance contrast and readability of active element.

Patch 1 by @david_nawrot

Patch 2 by @n.pineau

πŸ‡«πŸ‡·France vanessa.fayard

The patch works fine, thank you for adding a margin to the element.

πŸ‡«πŸ‡·France vanessa.fayard

While checking the patch, I noticed a problem of alignment in the case of adding only 1 type of paragraph.

css/paragraphs.claro.scss - 8

  // Add top margin to buttons to separate buttons,
  // because Claro theme sets that to 0.
   > .button {
      margin-top: 1rem;
  }

The margin-top should be set to . field-actions to handle all cases.
align-items: center is managed in issue 3417771

πŸ‡«πŸ‡·France vanessa.fayard

Verified and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.

before :

after :

The patch works fine.

May need to add padding/margin between button and text to improve UX.

πŸ‡«πŸ‡·France vanessa.fayard

Verified the #9 and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.
Followed the steps give by @emilymathew

Before :

After :

The patch works fine for me.

Production build 0.69.0 2024