πŸ‡«πŸ‡·France @vanessa.fayard

Account created on 13 December 2022, over 2 years ago
  • Web developer at EcediΒ 
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France vanessa.fayard

Hi,

The patch works for me (Drupal 11 - Gin 4.0), after clearing the cache.

Thanks for the issue and the patch!

πŸ‡«πŸ‡·France vanessa.fayard

Hi!

I tested the patch on Drupal 10.4 & better_exposed_filters ^7.0

It works on an single exposed filter (equal, less or greater)

It doesn't work on a exposed filter β€œbetween” (min - max)

πŸ‡«πŸ‡·France vanessa.fayard

Thanks for the feedback!

I've updated the MR. I've added the command documentation to the README.md.

Have a nice day!

πŸ‡«πŸ‡·France vanessa.fayard

Hello,
I have made an MR proposal. MR !10

I did not implement the interactive command because I encountered problems between version 12 and 13 of Drush. The ask() method changes drastically between these two versions.
So, I opted for a command with arguments and options to create the entity.

Example of command:

drush orejime:create-entity videos 'Youtube videos' --description="this is the description text" --publish --default

πŸ‡«πŸ‡·France vanessa.fayard

Un cafΓ©, de la musique, et c'est parti !
Programme du jour : contrib module contrib, traduction...

πŸ‡«πŸ‡·France vanessa.fayard

I've applied the MR!158 as patch and it applied successfully with no errors.

I have the same result as on the before and after reference screenshots.

Tested on Drupal 10.3.10 'drupal/paragraphs:^1.18'

Thanks

πŸ‡«πŸ‡·France vanessa.fayard

vanessa.fayard β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France vanessa.fayard

I've applied the MR!9 as patch and it applied successfully with no errors.

Tested on Drupal 10.3.2 with drupal/ckeditor_iframe: ^3.0@beta

Thanks

πŸ‡«πŸ‡·France vanessa.fayard

Patch update for D10 compatibility, from issue #3367901

Works on Drupal 10.2.7 - PHP8.2
Version : 1.0.2

πŸ‡«πŸ‡·France vanessa.fayard

Patch #17 - Verified and tested it on a Drupal 10.2.7 and PHP 8.2.19
The patch works fine.

Thanks

πŸ‡«πŸ‡·France vanessa.fayard

Hello,

Patches 1 and 2 successfully tested and validated.
Proposal 2 approved to enhance contrast and readability of active element.

Patch 1 by @david_nawrot

Patch 2 by @n.pineau

πŸ‡«πŸ‡·France vanessa.fayard

The patch works fine, thank you for adding a margin to the element.

πŸ‡«πŸ‡·France vanessa.fayard

While checking the patch, I noticed a problem of alignment in the case of adding only 1 type of paragraph.

css/paragraphs.claro.scss - 8

  // Add top margin to buttons to separate buttons,
  // because Claro theme sets that to 0.
   > .button {
      margin-top: 1rem;
  }

The margin-top should be set to . field-actions to handle all cases.
align-items: center is managed in issue 3417771

πŸ‡«πŸ‡·France vanessa.fayard

Verified and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.

before :

after :

The patch works fine.

May need to add padding/margin between button and text to improve UX.

πŸ‡«πŸ‡·France vanessa.fayard

Verified the #9 and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.
Followed the steps give by @emilymathew

Before :

After :

The patch works fine for me.

Production build 0.71.5 2024