Missing Margin for Paragraph Buttons in Claro Theme

Created on 10 November 2020, about 4 years ago
Updated 6 August 2024, 4 months ago

Problem/Motivation

Using the admin theme Claro with an add mode of 'Buttons' there is no vertical margin around the buttons so they run into each other.

Steps to reproduce

Create a paragraphs field, using the 'Buttons' add mode and sufficient paragraph types to cause the list of types to wrap.

Proposed resolution

Add 1 rem of bottom margin to the buttons or similar

Remaining tasks

Review/Commit

User interface changes

Visual bug need to be fix.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Postponed: needs info

Version

1.0

Component

User interface

Created by

🇬🇧United Kingdom timdavison

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India nayana_mvr

    Verified the patch #7 and tested it on Drupal version 10.1.x and Paragraphs module 8.x-1.x. The patch works fine and I have added the before and after screenshots for reference.

    Before patch

    After patch

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update 10 months ago
    182 pass
  • 🇺🇦Ukraine nginex

    In Drupal core 10.2 there selector is different, there is no more .form-actions, it's now .field-actions

  • 🇮🇳India emilymathew

    Verified the patch #9 and tested it on Drupal version 10.2.2 and Paragraphs module 8.x-1.17. The patch works fine and I have added the before and after screenshots for reference.

    Steps do to reproduce the issue.

    1. Installed Paragraphs module 8.x-1.17 in Drupal version 10.2.2.
    2. Changed the admin theme to Claro.
    3. Created 8 new paragraph types.
    4. Added a Paragraphs field to Basic page content type and selected all the 8 paragraph types I have created.
    5. Edit the Widget settings of Paragraphs field in Manage form display of Basic page content type and set the Add mode to "Buttons" from "Dropdown Button".
    6. Tried to add a new content in basic page, and it shows the paragraphs field without vertical spacing between items.
    7. Applied the patch in #9 and again tested, the spacing issue is fixed.
  • 🇮🇳India djsagar

    Verified the patch #9, it's resolved above issue.

    Follow the same steps which followed by @emilymathew,

    Sharing screenshots for reference:-

    RTBC ++

    Patch files are no longer recommended so create MR for the above.

  • 🇫🇷France vanessa.fayard

    Verified the #9 and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.
    Followed the steps give by @emilymathew

    Before :

    After :

    The patch works fine for me.

  • 🇫🇷France vanessa.fayard

    While checking the patch, I noticed a problem of alignment in the case of adding only 1 type of paragraph.

    css/paragraphs.claro.scss - 8

      // Add top margin to buttons to separate buttons,
      // because Claro theme sets that to 0.
       > .button {
          margin-top: 1rem;
      }
    

    The margin-top should be set to . field-actions to handle all cases.
    align-items: center is managed in issue 3417771

  • 🇮🇳India djsagar

    @vanessa.fayard i create MR in https://www.drupal.org/project/paragraphs/issues/3417771 📌 Some styling no longer applies due to form-actions -> field-actions html change Fixed for this issue.

    Kindly review.

  • Status changed to Postponed: needs info 4 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Based on my testing, it looks like other issues like 📌 Some styling no longer applies due to form-actions -> field-actions html change Fixed have resolved this at least partially as well, can't really see this on paragraphs 8.x-1.x-dev atm.

Production build 0.71.5 2024