πŸ‡¬πŸ‡·Greece @balis_m

Account created on 1 August 2013, almost 11 years ago
#

Recent comments

πŸ‡¬πŸ‡·Greece balis_m

Patch from #2 doesn' t apply to the current dev version. So, I rerolled it.

πŸ‡¬πŸ‡·Greece balis_m

In addition to the errors that patch #5 solves, this patch also solves the error in jsminplus.inc file.

πŸ‡¬πŸ‡·Greece balis_m

Patch from #184 works well, except range slider, that throws the following javascript error:

TypeError: unencoded is undefined

I've changed the slider event from "change" to "stop" and it works as expected.

πŸ‡¬πŸ‡·Greece balis_m

Hi, your patch does not make something different.

Moreover, it has a typo in comment and in MR you don't change the comment.

I re-attach the original one.

πŸ‡¬πŸ‡·Greece balis_m

Patch from #51 does not apply to Drupal 10.1.1. So, I rerolled it.

πŸ‡¬πŸ‡·Greece balis_m

Patch doesn' t apply to the current dev version. So, I rerolled it.

πŸ‡¬πŸ‡·Greece balis_m

Using Drupal 10 and commerce 8.x-2.x-dev with patch #141 throws the following error:

TypeError: Drupal\commerce_checkout\EventSubscriber\CheckoutCartEventSubscriber::checkRedirectIssued(): Argument #1 ($event) must be of type Symfony\Component\HttpKernel\Event\FilterResponseEvent, Symfony\Component\HttpKernel\Event\ResponseEvent given in Drupal\commerce_checkout\EventSubscriber\CheckoutCartEventSubscriber->checkRedirectIssued() (line 131 of modules/contrib/commerce/modules/checkout/src/EventSubscriber/CheckoutCartEventSubscriber.php).

This patch solves the TypeError issue and small coding standards issues.

Production build 0.69.0 2024