Regression: Unchecking a role entirely hides the parend details fieldset

Yeah I think it's this:

jQuery('input.role-expire-role-expiry', context)
          .parents('details')
          .hide();

Ok found it. It's all cases of .parents('details').

I'll prepare a MR with the tested fix.

LGTM!

Nice work. Thanks!

@anybody @grevil Changed selector with a custom class. Please, review.

Hi @rcodina thank you for the additional class, that totally makes sense!

Still I'd vote to add the :first selector behind the new class, as this is a performance optimization. We know, that there will be only one parent match. And this way we let jQuery know, that it doesn't have to look for further instances in the whole tree and can cancel. So the combination will be best.

Would you also like to add some JavaScript tests for the admin UI? Do you need guidance there?

@rcodina did that. I think we should merge this and tag a new release, before many projects become affected!

Makes sense. RTBC!

@anybody @grevil Fixed bug while testing. Please, review.

Thanks, LGTM!

Would you be interested in adding tests for the functionality? (Still I don't think this should be a blocker, instead this should be merged and a follow-up for JavaScript tests should be added then)

PS: Please also tag a new release then. People might still be in trouble due to the bugs in the last version.

Thanks to all.

@anybody Yes, let's open a follow up issue for the tests for this issue. In ✨ Add a new configurable email notification system Needs work I have done a JS test.

@anybody Just taged version 4.1.1.

Thank you!!

Automatically closed - issue fixed for 2 weeks with no activity.