Make the user expiration form field less prominent below the roles

Can you post a screenshot of the problem area? I want to be sure I understand the functionality you're describing.

Thanks @greggles yes of course!

Here it is:

It would be great if this could be more compact or collapsed, as long as unused, see proposed solutions above.

I think those fields might be in https://www.drupal.org/project/role_expire → ?

**** @greggles SORRY, I glitched into the wrong module indeed! I'll move it over, sorry!! Thank you!

@kuzyawkk thanks! Could you post a screenshot of the result maybe?

Hi @anybody, welcome. Yeah, I'm attaching screenshots with the result

I left some comments on the MR @kuzyawkk.
Maybe @rcondina would be so friendly to also take a maintainer look for feedback?

Thanks @rcodina GREAT WORK!

Not all help option messages are the same

Sorry I didn't see that.

I'll review the results now!

GREAT @rcodina! RTBC.

Testing this out took the idea even one step further, and I think it might make sense:
As long as there's no expiration date set for a role, we could even put the expiration field into the details and make the title "Role expire" or "Role expiration". If a value is set or the global option is disabled, the fieldset should be #open, otherwise closed.

That would make it even more compact and I think helpful! :)
What do you think?

PS: It might also make sense to add an indicator to the details title regarding the status ("No expiration" / "Expiration: XXX"). I think that would really be perfect then!

Setting this back to NW for the suggestions, what do you think? I think it's worth it...

@anybody Such a great idea! Could you please review it? Once done, I think it should be collapsed bu default!

Thanks @rcodina sorry I didn't come to that conclusion earlier and thank you for the great implementation, review in progress!

Great work, just some minor comments.

Any I think it makes sense to add an update hook setting
role_expire_expiration_field_visibility explicitly.

I'd vote to set it TRUE by default, even if it's kind of breaking change, it's not end-user related and it improves the UI / UX in the backend, so I think the majority would like to have this.

The update hook description should inform the users about the new feature and that they can disable it, if they would like to keep the old, expanded style?

REALLY AWESOME WORK!!

@anybody I think the new option "Expand role expiration fields by default" should be FALSE by default because it's much better. However, I agree for current module users we need an update hook to set it TRUE. You agree?

Yes, sorry if I wrote it the wrong way around. The new UI is much better for all!

@rcodina Super nice!

Just saw you decided to keep it open for existing installations:

/**
 * Automatically enable expanded role expiration details option.
 */
function role_expire_update_10002(&$sandbox) {
  \Drupal::configFactory()->getEditable('role_expire.config')->set('role_expire_expiration_details_expanded', TRUE)->save();
}

Is it for BC reasons?

While I'd vote to also collapse it for existing installations. I'd at least suggest changing the description a bit to inform updaters. The function description is shown in update.php and when running drush updb so maybe we should write something like:

Added new setting to expand / collapse the role expiration details in the user profile form. Setting default value: XXX. You can change the value on the role_expire settings page

RTBC anyway, feel free to decide which text you'd like to use.

Thank you so much for this great improvement!

@anybody With the suggested text, I think it's better to turn it FALSE by default for existing installs. Thanks all!

@rcodina yes I'm fine with that! :)

Let's go!

@rcodina any plans to merge this and maybe tag a new release?

Included in new 4.1.0 release.

Thank you very very much @rcodina!! :)

PS FYI: You don't have to set Closed (fixed) manually, Drupal.org will do that automatically after some weeks passed, if you just set it "Fixed". That's best practice.