Navigation's User Links menu should be added to Drupal CMS

MR added that imports all the config from the Navigation module. Since the Navigation module is under active development, and Christina is the UX lead for both the module and Drupal CMS, I think it is safe to assume that any config entities they add are meant for Drupal CMS also.

If I am wrong about this, we can list the two menu configs individually.

That seems like a reasonable approach to me.

My only question: is there anything that existing Drupal CMS sites need to do in order to adjust? If so, we'll need a change record.

I don't believe so. The commit contains an update hook that adds the menu if the user does not have it.

https://git.drupalcode.org/project/drupal/-/commit/f77a485d9141dcaf9c7bd...

/**
 * Creates the Navigation user links menu.
 */
function navigation_post_update_navigation_user_links_menu(array &$sandbox): void {
  $menu_storage = \Drupal::entityTypeManager()->getStorage('menu');

  // Do not create the new menu if already exists.
  if ($menu_storage->load('navigation-user-links')) {
    return;
  }

  $menu_storage
    ->create([
      'id' => 'navigation-user-links',
      'label' => 'Navigation user links',
      'description' => 'User links to be used in Navigation',
      'dependencies' => [
        'enforced' => [
          'module' => [
            'navigation',
          ],
        ],
      ],
      'locked' => TRUE,
    ])->save();
}

Nah we don't want all the config because we don't want Help or Shortcuts, which come with navigation.block_layout.yml. But agree we should update it for this change.

Good to know. I just updated it to only import the two menus.

The test failure is legit, unfortunately. This probably needs some level of manual testing to be sure no broken blocks are showing up in the navigation.

I manually tested this and was perplexed about why the content menu didn't get imported, but it was just a typo in the recipe that I fixed.

I'm not sure why we aren't importing the settings file but we don't seem to need it.

Simple config files are always imported.

Thanks for fixing my copy pasta error!

Merged into 2.x and cherry-picked to 1.2.x. Thanks!