- Issue created by @a.dmitriiev
- Merge request !10326Issue #3489583: Provide config action to set editor plugin configuration β (Closed) created by a.dmitriiev
- π©πͺGermany a.dmitriiev
Added the test, the failed test in the latest pipeline is from block module
- π³πΏNew Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
There are over 1000 changes in the MR. I think something happened when you switched branches.
Moving to Needs Work.
- Merge request !10500Issue #3489583 by a.dmitriiev: Provide config action to set editor plugin configuration β (Open) created by a.dmitriiev
- π©πͺGermany a.dmitriiev
I have opened the new MR with correct target branch
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Looks great. I made one little nit.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
I read the IS, comments and the MR. I didn't find any unanswered questions or other work to do.
- Status changed to Needs work
about 1 month ago 5:19pm 3 March 2025 - π¬π§United Kingdom catch
This looks like it's generic for any editor, but it's exposed by the ckeditor5 module and hard-codes itself to only support ckeditor5. Why can't it be provided by the editor module and work generically? If there's a good reason why it can't, then I think the plugin ID should be namespaced to the ckeditor5 module at least, and also the issue summary and inline comments should explain why it's not generic.
- π©πͺGermany a.dmitriiev
The plugin manager that is used in the config action is from CKEditor5 module and it assumes that the plugins will be for CKEditor5. Is there a generic plugin manager for any editor? I think that each editor has its own plugin type, or?