- Issue created by @phenaproxima
- Merge request !543Adopt the unpacker plugin and see what breaks β (Merged) created by phenaproxima
- π¬π§United Kingdom catch
This is probably the riskier proposition, since deployments that depend on doing a composer install at the remote end, then reapplying the recipes, will not work
Trying to think of a use-case for this workflow, but struggling a bit.
I would expect that people would apply the recipes locally, export configuration, and commit the configuration to git, then import it on production (same as config changes without recipes). Or.. if they're building a recipe-based hosted demo or similar that they'd commit the recipes themselves to git. As long as those two work, then breaking a workflow of composer install locally + recipe apply remote without either exporting config or committing to git seems fine.
- πΊπΈUnited States phenaproxima Massachusetts
Re #5: Yeah, I'm not necessarily saying it's a workflow that anyone would actually use, but I merely raise it because people have all sorts of wonky workflows and this could be a major change to some of them. I guess this is merely a call for strong documentation.
- πΊπΈUnited States phenaproxima Massachusetts
How to manually test this:
composer create-project drupal/cms:dev-recipe-unpack -s dev --repository='{"type":"vcs","url":"https://git.drupalcode.org/issue/drupal_cms-3524255.git"}' DIRNAME
Everything should install as normal, and you should be able to install Drupal CMS, but you should also see many modules added to the top-level composer.json, and few (if any) recipes.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
The code in this merge request looks fine, but I think the ideal situation would be to also remove the recipes from the code base.
Like project browser can list and install projects from Drupal.org's JSON API, I feel like we should also have a browser that would list the approved Drupal CMS recipes from Drupal.org. When a user chooses to apply a recipe, the recipe is downloaded, applied, unpacked, and removed in one step.
That way, the recipe is truly ephemeral, and the user gets the latest version when they choose to browse and apply.
- πΊπΈUnited States tim.plunkett Philadelphia
thejimbirch β credited tim.plunkett β .
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Adding credit for discussions in slack.
-
phenaproxima β
committed f482db45 on 2.x
Issue #3524255 by phenaproxima, thejimbirch, pameeela, catch, tim....
-
phenaproxima β
committed f482db45 on 2.x
-
phenaproxima β
committed a44e336b on 1.2.x
Issue #3524255 by phenaproxima, thejimbirch, pameeela, catch, tim....
-
phenaproxima β
committed a44e336b on 1.2.x
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 2.x and cherry-picked to 1.2.x.