- Issue created by @mpotter
- πΊπΈUnited States phenaproxima Massachusetts
Fully agreed that we need this. I can get this written pretty fast.
- πΊπΈUnited States mpotter
Using this:
editor.editor.content_format: addItemsToToolbar: - item_name: aickeditor - item_name: aiAgentButton
I get the error:
PHP Fatal error: Cannot declare class Drupal\ckeditor5\Plugin\ConfigAction\AddItemToToolbar, because the name is already in use in /var/www/docroot/core/modules/ckeditor5/src/Plugin/ConfigAction/AddItemsToToolbar.php on line 16
- πΊπΈUnited States mpotter
Tested the patch manually and it worked for my site.
- πΊπΈUnited States nicxvan
Please keep the standard issue summary second, it makes it easier to review as the issue progresses.
I think this will be a great addition!
- πΊπΈUnited States nicxvan
Php Stan is failing for covers and one question in the MR.
- Status changed to Needs work
25 days ago 11:24am 2 June 2025 - First commit to issue fork.
- π§πͺBelgium svendecabooter Gent
Rebased the MR on current 11.x to resolve merge conflict.
- π§πͺBelgium svendecabooter Gent
All code review issues have been fixed, and extra explanation has been provided.
Setting this to Needs Review. - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Added Needs change record tag.
- πΊπΈUnited States mpotter
Is anyone able to post a `.patch` file from before the rebase to the current 11.x-dev that still applies to the 11.1.7 release version? I was referencing this MR and didn't download the diff locally, so now my build is broken because this latest patch no longer applies. The rebase is going to make recreating the patch for 11.1.7 a lot of work.
- πΊπΈUnited States nicxvan
I think there is a tag when there is a force push.
You can also go to the changes team and select an older version.
This highlights why a diff should never be directly referenced.
- πΊπΈUnited States mpotter
I do not see any tags in this MR. I also don't see how to select an older version in the changes "tab". I think the rebase modified the commit history or something.
In any case, I spend the last hour manually getting a patch that applies to 11.1.7 and am uploading it for myself and others to use.
- πΊπΈUnited States mpotter
except that still doesn't seem to apply to my project. Let me check if I've got another patch interfering with this.
- πΊπΈUnited States mpotter
ok, it was a problem with my local file paths. This patch should work with 11.1.7 now
- πΊπΈUnited States nicxvan
I've attached a screenshot of what I meant.
This is getting a bit off topic, so feel free to move comments to the issue about static patches, or ping me in slack.
Also yes, rebasing by definition changes history, it rolls back the changes you've made on the current branch, applies the changes on the branch you're rebasing onto then tries to re-apply the changes you've made.
- πΊπΈUnited States smustgrave
Also agree with the comment in the MR could that be cleaned up some?