- Issue created by @traviscarden
- Merge request !191#3469551: Clarify commands in CONTRIBUTING.md, and provide XB DDEV add-on alternate commands → (Merged) created by traviscarden
- Status changed to Needs review
2 months ago 9:36pm 21 August 2024 - Status changed to RTBC
2 months ago 5:25am 22 August 2024 - 🇮🇳India diwakar07
Hi,
I reviewed MR !191.
It fixes the issue and the changes look good to me.Moving to RTBC!
Thanks,
Diwakar. - Assigned to traviscarden
- Status changed to Needs work
2 months ago 7:25am 22 August 2024 - Assigned to wim leers
- 🇺🇸United States traviscarden
Regardless, either configuration is a perfectly valid way to run and develop Drupal. I don't want to increase the documentation burden by duplicating every command to account for it.
I've tried to render the question irrelevant for the greatest number of people by just creating a DDEV command for it in our add-on at TravisCarden/ddev-drupal-xb-dev:
ddev xb-phpcs
. That way whoever uses our add-on doesn't have to know or care about the difference.I defer to you on what to do with this issue, @Wim Leers. I have no problem with "Closed (won't fix)".
- Assigned to traviscarden
- Status changed to Needs review
2 months ago 8:19am 23 August 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'd love to clarify
/CONTRIBUTING.md
, because I'm certain you won't be the only one running into this :)One more question + one suggestion on the MR 😊🏓
- 🇺🇸United States traviscarden
traviscarden → changed the visibility of the branch 3469551-1 to hidden.
- 🇺🇸United States traviscarden
traviscarden → changed the visibility of the branch 3469551-1 to active.
- 🇺🇸United States traviscarden
traviscarden → changed the visibility of the branch experience_builder-3466555 to hidden.
- 🇺🇸United States traviscarden
Oops. Pushed a branch to the wrong issue. Disregard.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@traviscarden Don't worry — happens to me all the time 😅 (The issue fork workflow is pretty painful like that … 🫤)
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@traviscarden WDYT about my remarks on the MR? I'd love to merge docs improvements! 🤓
- Issue was unassigned.
- Status changed to RTBC
about 2 months ago 1:15pm 4 September 2024 -
wim leers →
committed a632a014 on 0.x authored by
traviscarden →
Issue #3469551 by traviscarden, wim leers: Clarify commands in...
-
wim leers →
committed a632a014 on 0.x authored by
traviscarden →
- Status changed to Fixed
about 2 months ago 1:30pm 4 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.