- Issue created by @aaron.ferris
- Assigned to charlliequadros
- Status changed to Needs review
10 months ago 11:56am 7 June 2024 - 🇬🇧United Kingdom aaron.ferris
Hi @charlliequadros - thanks for this!
One flag from phpcs please: https://git.drupalcode.org/issue/menu_css_names-3453023/-/jobs/1804541
-------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 81 | WARNING | Avoid backslash escaping in translatable strings when possible, | | use "" quotes instead | | (Drupal.Semantics.FunctionT.BackslashSingleQuote)
- Status changed to Needs work
10 months ago 2:15pm 7 June 2024 - Status changed to Needs review
10 months ago 4:57pm 7 June 2024 - Status changed to Needs work
10 months ago 4:14am 8 June 2024 - 🇮🇳India diwakar07
Hi @charlliequadros,
I reviewed the MR !15.
Looks good to me, It adds a help page for the module.
Just a small typo in the help page description, please updatetheme\'s configuration
totheme's configuration
Attached is the SS for reference.Moving to NW.
- 🇬🇧United Kingdom aaron.ferris
Thanks @Diwakar07
Ive made a couple of minor tweaks to this, looks good to me though, Menu CSS names shows in admin/help and is representative of the modules functionality.
Merging.
- Issue was unassigned.
- Status changed to Fixed
10 months ago 11:54am 8 June 2024 - Status changed to Fixed
10 months ago 12:01pm 8 June 2024