- Issue created by @pameeela
- Merge request !246Issue #3490108: Added the optional config files for claro. → (Merged) created by diwakar07
- 🇮🇳India diwakar07
Hi,
Created an MR for adding the basic block configs for claro admin theme.
Added the configs in the admin_ui recipe, the site no more breaks and the sections look good.
The site branding section block looks weird with logo and site name with one below another.Please review.
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Thanks for working on this @diwakar07
I made some suggestions inline for improving the changes.
- 🇮🇳India diwakar07
Hi,
Thanks for the review @thejimbirch.I have the updated the MR accordingly.
The config files are getting imported from claro as expected, but I see a block missing error. Will debug regarding it.
Attaching SS for the same. - 🇮🇳India diwakar07
Hi,
Updated the MR to fix the "Missing block" message.
Updated the recipe file to import only the necessary block configurations instead of using "*" to import all configurations.
The admin Ui looks good now.Please review.
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Questions for you on the MR. Thanks for your continued work on this.
- 🇮🇳India diwakar07
Hi @thejimbirch,
Thanks for the review.I have removed the old config files and the same from the recipe file as well.
Also updated the recipe file to import the configs as provided by claro.Can you please review the current/latest changes ?
Please let me know if any changes are required here.
MR Link: https://git.drupalcode.org/project/drupal_cms/-/merge_requests/246/diffsThanks.
- 🇦🇺Australia pameeela
Looks good, I just reordered the files to alphabetical so they match Gin.
-
phenaproxima →
committed 5d2409ee on 0.x authored by
diwakar07 →
Issue #3490108 by diwakar07, pameeela, thejimbirch: Claro gets installed...
-
phenaproxima →
committed 5d2409ee on 0.x authored by
diwakar07 →
- 🇺🇸United States phenaproxima Massachusetts
Thanks for fixing this oversight. Merged into 0.x!
Automatically closed - issue fixed for 2 weeks with no activity.