- Issue created by @japerry
- last update
about 1 year ago 15 pass - last update
about 1 year ago 15 pass - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ made their first commit to this issueโs fork.
- Status changed to Needs review
12 months ago 1:16pm 17 July 2024 - Status changed to RTBC
12 months ago 1:02pm 22 July 2024 - ๐ฎ๐ณIndia diwakar07
Hi,
Reviewed MR !8.The gitlab ci file added follows the proposed standards. We can have separate tickets for fixing the phpcs and cspell warnings.
Looks good to me.
Moving to RTBC.Thanks.
- Assigned to m4olivei
- Status changed to Needs work
7 days ago 7:51pm 27 June 2025 - ๐จ๐ฆCanada m4olivei Grimsby, ON
Looks like there are a few issues here. cspell and phpcs jobs are failing. Those fixes look quick and easy, might as well include. The Gitlab CI template has also been slightly updated: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...
We may as well include the latest.
I'll tidy things up here.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Made some adjustments including:
- Updated .gitlab-ci.yml template for latest
- Within .gitlab-ci.yml marked only testing 10.x as the module isn't compatible as 11.x yet. See ๐ GitLab CI testing Needs review
- Fixed cspell issues
- Fixes phpcs issues
Pipeline is green!