Provide more granular permissions

Thanks everyone for the work on this important change to this module. I tested the patch from #24 and it worked for me, on PHP 8.1 / Drupal 9.5.8 / simple_sitemap 4.1.4. Looks good to me. This was marked 'needs work' but it doesn't look like it needs work. I changed it to 'Needs review' but if I am wrong please feel free to set it back to 'needs work'. RTBC in my book.

Note that the patch will cause fatal errors with the simple_sitemap_engines module, since Drupal\simple_sitemap_engines\Form\FormHelper extends Drupal\simple_sitemap\Form\FormHelper.

Fatal error: Declaration of Drupal\simple_sitemap_engines\Form\FormHelper::formAlterAccess(): bool must be compatible with Drupal\simple_sitemap\Form\FormHelper::formAlterAccess(Drupal\Core\Entity\EntityFormInterface $form_object): bool in /app/web/modules/contrib/simple_sitemap/modules/simple_sitemap_engines/src/Form/FormHelper.php on line 63

I couldn't apply the MR 38 patch to I checked out the branch locally and merged 4.2.1 and made a diff.

This patch should work for 4.2.1

Reviewed MR38, tested manually and it works!

walkingdexter → credited alexander tallqvist → .

walkingdexter → credited andreastkdf → .

walkingdexter → credited diwakar07 → .

walkingdexter → credited leopathu → .

Simplified and committed, thanks! Thoughts from #21 are respected. Credits saved for the guys from ✨ New permission to only edit entity sitemap settings Needs review .

walkingdexter → closed merge request !38

Automatically closed - issue fixed for 2 weeks with no activity.