- Issue created by @batigolix
- First commit to issue fork.
- Status changed to Needs work
26 days ago 12:04pm 31 May 2024 - 🇯🇵Japan ptmkenny
Changing the issue title back because this MR fixes phpcs, eslint, and cspell tests but not phpstan. Phpstan should be handled in a separate issue.
- Status changed to Needs review
24 days ago 1:24pm 2 June 2024 - 🇮🇳India Diwakar07
Moving to Needs review, since phpcs, eslint, and cspell have been fixed in the MR.
Please review. - Status changed to RTBC
24 days ago 1:58pm 2 June 2024 - 🇯🇵Japan ptmkenny
These changes look good to me and have consistent formatting. Moving to RTBC.
One additional change to be considered by the maintainer:
Since the phpcs, eslint, and cspell tests are now passing, they can be required so that future MRs do not break them (by default, GitLab CI only requires the phpunit tests to pass).
You can do that by adding the following to .gitlab-ci.yml:
# Require all tests to pass. cspell: allow_failure: false eslint: allow_failure: false phpcs: allow_failure: false - Status changed to Needs work
23 days ago 7:55am 3 June 2024 - 🇳🇱Netherlands batigolix Utrecht
@ptmkenny : yes, that requirement would be great. So this should be added
It is OK to ignore phpstan for the moment. I ll make a new issue for that
- Status changed to Needs review
23 days ago 8:26am 3 June 2024 -
batigolix →
committed 3b567ed8 on 2.3.x
Issue #3451535: GitLab CI: Fix phpcs, eslint, and cspell tests
-
batigolix →
committed 3b567ed8 on 2.3.x
- 6b8a7876 committed on 2.3.x
Issue #3451535 by Diwakar07, batigolix, ptmkenny: GitLab CI: Fix phpcs,...
- 6b8a7876 committed on 2.3.x
-
batigolix →
authored cec02bbf on 2.3.x
Issue #3451535: GitLab CI: Fix phpcs, eslint, and cspell tests
-
batigolix →
authored cec02bbf on 2.3.x
- Status changed to Fixed
23 days ago 11:10am 3 June 2024 - 🇮🇳India Diwakar07
Hi, @batigolix
Thanks for the update and for closing this issue.
However, I noticed that there was no credit given for resolving this issue.
Is there something we are missing? - 🇳🇱Netherlands batigolix Utrecht
Correct, when merging I did not check the authors. I followed up with a commit for the credits. Is that Okay for you?
- 🇮🇳India Diwakar07
Hi @batigolix,
Thanks for the update.
But I still do not see any credit towards my name for this issue. - 🇦🇺Australia ELC
Credit as displayed on the d.o website in user profiles & org stats is set by the maintainer when posting to the issue.
See "Credit & committing" header below where it currently states "A maintainer has not commented and given credit yet.".
A maintainer needs to tick the appropriate boxes, and/or manually add users who are not listed in the list but who contributed, and then submit a comment.
Details instructions are available from the link in "Learn more about granting credit. → "
This step has been missed on most recent issues.
- 🇳🇱Netherlands batigolix Utrecht
Yes, I agree. I missed this because I use the merge request option in the issue form.
It is more obvious to copy the correct commit message when you. do the commits on your local machine.Apologies for this and I will try to credit you in the upcoming issues.
Automatically closed - issue fixed for 2 weeks with no activity.