GitLab CI: Fix phpcs, eslint, and cspell tests

Changing the issue title back because this MR fixes phpcs, eslint, and cspell tests but not phpstan. Phpstan should be handled in a separate issue.

Moving to Needs review, since phpcs, eslint, and cspell have been fixed in the MR.
Please review.

These changes look good to me and have consistent formatting. Moving to RTBC.

One additional change to be considered by the maintainer:

Since the phpcs, eslint, and cspell tests are now passing, they can be required so that future MRs do not break them (by default, GitLab CI only requires the phpunit tests to pass).

You can do that by adding the following to .gitlab-ci.yml:

# Require all tests to pass.
cspell:
  allow_failure: false
eslint:
  allow_failure: false
phpcs:
  allow_failure: false

@ptmkenny : yes, that requirement would be great. So this should be added

It is OK to ignore phpstan for the moment. I ll make a new issue for that

@batigolix Ok, added!

Hi, @batigolix
Thanks for the update and for closing this issue.
However, I noticed that there was no credit given for resolving this issue.
Is there something we are missing?

Correct, when merging I did not check the authors. I followed up with a commit for the credits. Is that Okay for you?

Hi @batigolix,
Thanks for the update.
But I still do not see any credit towards my name for this issue.

Credit as displayed on the d.o website in user profiles & org stats is set by the maintainer when posting to the issue.

See "Credit & committing" header below where it currently states "A maintainer has not commented and given credit yet.".

A maintainer needs to tick the appropriate boxes, and/or manually add users who are not listed in the list but who contributed, and then submit a comment.

Details instructions are available from the link in "Learn more about granting credit. → "

This step has been missed on most recent issues.

Yes, I agree. I missed this because I use the merge request option in the issue form.
It is more obvious to copy the correct commit message when you. do the commits on your local machine.

Apologies for this and I will try to credit you in the upcoming issues.

Automatically closed - issue fixed for 2 weeks with no activity.

Crediting the people that helped out. Thanks

Hi @batigolix,

I understood the fact that you missed the crediting step.
I later got to learn that it is up to the maintainer to decide whether to credit people or not for working on an issue.

Appreciate the time you spent going back and crediting people for their work on this issue.
Hope my work on this issue was helpful, and I did not trouble much with the credit comments.

Received the credit for the issue.

Thanks,
Diwakar.