Merge the two status messages on install

I'll look into it.

Is this related / duplicate of 📌 Review the messages that appear on the initial page after install Postponed ?

Thanks @poker10, I totally forgot I made that placeholder! I've closed that one since I made two separate ones for the specific issues.

Hi,
Created an MR for removing the second status message.
Adding SS for reference.

Please review.

I'll be honest - I don't really want to duplicate install_finished() at all. The problem here is really fundamental - messages are not identified in any particular way and they cannot be easily removed from the "flash bag" that they're in.

I'd actually like to try a little bit of experimentation; if the container is alterable during the installer (and it might not be), maybe we could set a custom messenger that specifically rejects the "Congratulations, you installed Drupal CMS!" message. It's trickier, but it would be cleaner and it would give us a way to reject other messages too.

I'll give that a try in another branch, just because I like doing mad science.

I was able to get it to work my way, so I'd prefer to do that instead. You will still get a commit credit, @diwakar07, since you took a stab at it. :) Would you be able to test my MR (!223), and set this issue to RTBC if it works for you?

Also giving this to @pameeela for final review.

Hi phenaproxima,
Thanks for reviewing my MR! I was also hesitant about this approach since it involved reusing the code.
That said, your suggestion regarding the approach is fantastic—it didn’t occur to me while I was working on it.
I’m definitely planning to experiment with other services using this method.

I have reviewed MR !223, the changes and the approach looks great and extensive as well.
It successfully removes the "Congratulations, you installed Drupal CMS!" from the page.

Moving to RTBC!

Wouldn't it be more beneficial for users to keep the string Congratulations, you installed Drupal CMS! so that the users are aware that the installation was succesfull?

So yes, removing the second message (as the MR 223 does) is ok, but could we also update the existing status message:
Make a note of your login details to access your site later:
to something like this:
Congratulations, you installed Drupal CMS! Make a note of your login details to access your site later:?

Updating the existing message is out of scope for this issue, which is just to remove the duplicated messages.

We will finalise the messaging with the help of the UX team.

Can we take the same approach to 📌 Confusing warning message on install with DDEV Active ?

#17: This doesn't remove the possibility of duplicated messages. It just suppresses the one. BUT...this does open the door to being able to combine multiple messages of a particular type, into a single message. We can do that in another issue. And yes, we could use this infrastructure to suppress the weird "permissions were changed" warning when in DDEV.

So long as we're both clear on the scope here, do you approve of this one as-is?

Pam okayed this in Slack, so...merged into 0.x!

> This doesn't remove the possibility of duplicated messages.

Yeah, I get that it's just targeting specific ones. But I'm not sure that we should blanket merge messages of the same type, it would be useful to see some other scenarios. Because I can imagine it being potentially confusing to show several arbitrary messages together?

For now, happy with this and we can handle other messages as they come up.

Automatically closed - issue fixed for 2 weeks with no activity.