- Issue created by @dinarcon
- Merge request !5Issue #3489993: Added empty check for auto_increment_alter_tables and... → (Merged) created by Unnamed author
- 🇮🇳India rohan_singh India
Hi @dinarcon, I have raised an MR. Do let me know if I can help in any other way.
Please review.Thanks
Rohan Singh - 🇳🇮Nicaragua dinarcon
Thanks @rohan_singh for working on this. I reviewed the MR and requested some changes. The
?? NULL
is not needed and can be removed. Back to needs work. - 🇮🇳India rohan_singh India
Hi @dinarcon, thank you for the review. I have made the necessary changes needed.
- First commit to issue fork.
- 🇳🇮Nicaragua baltowen
Hi @rohan_singh, thanks for the MR. I tested it and notice that there was an undefined variable. I replaced the wrong name with the proper one. I also replaced the usage of empty because Drupal PHPStan rules recommend against it. And finally I fixed a typo in the error message.
-
dinarcon →
committed f6f2bd8d on 1.0.x authored by
rohan_singh →
Issue #3489993 by rohan_singh, dinarcon, baltowen: Log an error if the...
-
dinarcon →
committed f6f2bd8d on 1.0.x authored by
rohan_singh →
- 🇳🇮Nicaragua dinarcon
Thanks for updating the MR @rohan_singh. Good catch of the undefined variable @baltowen. I pushed a commit to have separate messages when the variables are
NULL
vs an empty array. If a user places the configuration in the wrong location, it would be better to be explicit about such configuration not being set.Tested the two affected service methods / Drush commands. Things are working as expected.
Automatically closed - issue fixed for 2 weeks with no activity.