- Issue created by @SocialNicheGuru
- First commit to issue fork.
- 🇮🇳India rohan_singh India
@akalam and @tonibarbera, I have raised a PR for the ECA 2.x support. Kindly review and merge this.
- Status changed to Needs review
6 months ago 1:44pm 7 July 2024 This will allow to install module, but I don't think it will go further than that.
At least I get below error:
ECA ran into error from third party in the context of "Collecting all available actions": Cannot override final method Drupal\eca\Plugin\Action\ActionBase::__construct() Line 35 of /Applications/MAMP/htdocs/test/web/modules/message_notify_eca/src/Plugin/Action/MessageNotify.phpSeems __construct() needs to be rewritten, but haven't solved it yet.
- Status changed to Needs work
6 months ago 11:34am 8 July 2024 -
Rohan_Singh →
committed 05cb58c1 on 1.0.x
Issue #3459764: Added Support for ECA 2.x.
-
Rohan_Singh →
committed 05cb58c1 on 1.0.x
- First commit to issue fork.
- Merge request !4Resolve #3459764 "Update messagenotifyeca to constructor" → (Closed) created by tonibarbera
-
tonibarbera →
committed 84614d4f on 1.0.x
Issue #3459764: Update message_notify_eca to use eca 2.x
-
tonibarbera →
committed 84614d4f on 1.0.x
- 🇪🇸Spain tonibarbera
I've updated the constructor. It should work now with Drupal 10.3
- Status changed to Needs review
5 months ago 11:53am 31 July 2024 -
tonibarbera →
committed 08ceaeb0 on 1.0.x
Issue #3459764: Update message_notify_eca to use eca 2.x
-
tonibarbera →
committed 08ceaeb0 on 1.0.x
- Status changed to Fixed
5 months ago 5:56pm 2 August 2024 - 🇪🇸Spain akalam
@monkk the constructor is declared as final on ActionBase on ECA v2, so it can't be overridden. We have removed that override and used an alternative method for dependency injection.
This should be fine in beta5.
Thanks for reporting Automatically closed - issue fixed for 2 weeks with no activity.