data-drupal-selector isn't stable since 8.9.0

Created on 9 September 2020, about 4 years ago

Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Form widget/fields id attributes have changed since drupal 8.9.0

Steps to reproduce

Simply add an exposed filter in a view. Id attributes wil be suffixed by a number.
(In my case some date picker fields ids have changed from id="edit-field-date-value" to id="edit-field-date-value--2")

This was introduced by #1831560: Remove Html::resetSeenIds() call during form processing →

User interface changes

Strictly speaking we cannot say this is a regression, because drupal works perfectly...
But for those who enrich their form widgets with javascript, via ID selectors, obviously they will find fatal regressions, without errors.

Conclusion

This may be a non fix to revert this patch...?
For other people there, check your javascript id selectors in your cutom code when upgrading to drupal 8.9 or 9.0 !

🐛 Bug report

Status

Closed: duplicate

Version

9.5

Component

Form →

Last updated about 12 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇫🇷France pguillard

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs accessibility review
Used to alert the accessibility topic maintainer(s) that an issue significantly affects (or has the potential to affect) the accessibility of Drupal, and their signoff is needed (see the governance policy draft for more information). Useful links: Drupal's accessibility standards, the Drupal Core accessibility gate.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

I wonder if this is an actual issue? Isn't it an accessibility issue to have duplicate IDs on a page? Or am I understand the issue wrong?

If an actual bug could use a test case to show the issue.
Status changed to Closed: duplicate almost 2 years ago9:06am 30 January 2023
Comment almost 2 years ago →
🇳🇱Netherlands idebr
This issue is still relevant, but is being fixed in 🐛 $form['#attributes']['data-drupal-selector'] is set to a random value so can't be used for its intended purpose Needs work . I'll close this issue as a duplicate.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024