🇳🇱Netherlands @Sutharsan

Patch merged. Thanks for contributing.

Version 4.0.3 was released with core_version_requirement: ^9 || ^10. Is this issue still now resolved?

Please mark this issue 'closed' when it is resolved.

@jrockowitz, Thanks for this. I'll make a new release for this.

@kimberleycgm, thanks for working on this. Uploading a patch is not needed, Gitlab provides it for you (the 'plain diff' link to https://git.drupalcode.org/project/mailchimp/-/merge_requests/46.diff)

1. +++ b/README.md
   @@ -119,6 +119,14 @@ value is treated and how it behaves over time.
   +The ratio of incidents to process. For example: 1 or 0.5 or 0.005 etc. Lower the value to reduce backend server load on high traffic sites.
   

   I would add an example: "For example with a process ration value of 0.2, every fifth page hit (on average) will trigger an incident. The emitted energy per incident is the configured value multiplied by 5."

2. +++ b/src/Plugin/Field/FieldFormatter/RadioactivityReferenceEmitter.php
   @@ -125,6 +186,9 @@ class RadioactivityReferenceEmitter extends RadioactivityReferenceFormatterBase
   +    // Set custom cache tag to invalidate on incident process ratio config change.
   

   Comment is longer than 80 chars.

I have checked the code and this is the only ::getQuery() that currently lacks an access check.
The changes look good, test is green.

Thanks for working on this issue!

1. +++ b/README.md
   @@ -119,6 +119,14 @@ value is treated and how it behaves over time.
   +The emitted energy for a processed incident is divided by the incident process ratio to make the total emitted energy for a certain amount of incidents independent of the incident process ratio setting. This means the incident process ratio setting will not affect the average amount of energy a incident will emit.
   

   I don't understand this.

   1. Explain why lowering the value is good on high traffic sites. 2. Describe if it is ok to modify the value on an existing site.

   I think you mean multiply instead of divide (not implemented?). But personally I would not bother explaining it.

2. +++ b/src/Form/SettingsForm.php
   @@ -0,0 +1,82 @@
   +      '#description' => $this->t('The ratio of incidents to process.') . t('Lower the value to reduce backend server load on high traffic sites.') . '<br/><br/>' . $this->requirementDescription() . '<br/>' . $this->t('For example: 1 or 0.5 or 0.005 etc.') . '<br/><br/>' . t('The emitted energy for a processed incident is divided by the incident process ratio to make the total emitted energy independent of the incident process ratio setting.'),
   +      '#default_value' => $this->config('radioactivity.settings')->get('incident_process_ratio') ?? 1,
   

   concatenating t function results will only work correct in left-to-right languages and not in right-to-left ones. Keep string on together. However
   separated strings may be concatenated as strings (= r-t-l safe)

   Only use $this->t() not t() in classes.

3. +++ b/src/Form/SettingsForm.php
   @@ -0,0 +1,82 @@
   +    // Clear cache to make sure the javascript is not cached.
   

   Use short array syntax.

   The reference to javascript is confusing to me. The cache contains the field formatter (which in turn contains some JS).

4. +++ b/src/Form/SettingsForm.php
   @@ -0,0 +1,82 @@
   +    Cache::invalidateTags(array('radioactivity_incident_process_ratio'));
   

   Use short array syntax!

Duplicate of 🐛 Class "DrupalCodeGenerator\Command\BaseGenerator" not found RTBC

@robphillips, you assigned several issues to yourself, it usually means that you are working on the issue. Is this still your intention to work on them? If not, pls unassign to clear it for others to work on.

I've created a follow-up for the remaining entities: 📌 Prevent error on entity getters Fixed

Sutharsan → created an issue.

The fault can happen on all entity properties that have NULL as default value and have the same code construction in the getter:
$this->get('foo')->first()->getValue()['value'];

All getters of the L10nServerTranslationHistory entity have the same potential problem. This patch fixes them in the same manner.

Answering the question to start with, I value most the top contributors, followed by team and the statistics.

The the current contributor list and statistics do not provide great value. What. It does provide is:

• How small/large the community is, how active
• Who are top contributors, who is experienced, who can I trust
• What is the state of reviews, is there a small or large pool of to be reviewed, what is the chance of getting my stuff reviewed

All this info is only usefull for the big picture not for everyday translation work.
And it only counts approved translations, not (open or rejected) suggestions, in other words, it is biased towards the experienced translators.

A redesign of contributor list and statistics towards usefulness for both the big picture and everyday work is interesting, but beyond the scope of this issue.

quietone → credited Sutharsan → .

The Math.random() function returns a floating-point, pseudo-random number in the range [ 0, 1) that is, from 0 (inclusive) up to but not including 1. So I believe the comparison Math.random() <= …is not correct.

The readme document should be extended with a description of the new setting.

What is the rationale of having the new setting per field instance? What is the advantage of having this per field instance? I see possible problems when for example comparing values.

Can not reproduce.

@msn5158, can you describe the situation in which this occurs? Preferably in the form of steps to reproduce?

It is logical to _not_ limit access in this query. Agree with the solution, code looks good.

Fixing bug introduced by #5

Re-rolled for latest 8.x-2.0 release.

🐛 Field default value does not show in the block Needs work is not expected to be fixed soon. This patch fixes the issue.

Fixes small error. Remove @throw documention, it no longer applies.

If this still occurs in the latest release, feel free to reopen the issue with details on how to reproduce the error.

Reverting a part of the fixes as it breaks submitting block configurations.

Sutharsan → created an issue.

Refactor the patch.

Re-rolled the patch because it no longer applied.

I've updated the project page with the updated description by from @racinggrinner and @batigolix. A documentation page of the module does not exist, I leave that to others to create.

Where do I find the Site administrators, which issue queue or Slack channel?

Thanks all, I will proceed with that.

@gisle, Can you delete a project? That could be the alternative. And if not, who can?

Sutharsan → created an issue.