Error on node revision route due to core type upcasting change

Created on 23 May 2022, over 2 years ago

Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Drupal core 9.3 updated the typecasting for the node_revision → route parameter which means it's a fully fledged object now. The code in this module for getting the entity is using code that thinks it's the revision id, a numeric value, which then throw this error:

TypeError: Illegal offset type in Drupal\Core\Entity\ContentEntityStorageBase->loadRevision() (line 639 of /var/www/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php)
#0 /var/www/docroot/modules/contrib/fieldblock/src/Plugin/Block/FieldBlock.php(461): Drupal\Core\Entity\ContentEntityStorageBase->loadRevision(Object(Drupal\node\Entity\Node))

Steps to reproduce

Install the module
Create a node with revisions
Click on the Revisions tab, click to view one of the revisions, observe WSOD

Proposed resolution

See attached patch.

Remaining tasks

User testing

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States nsciacca

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇨🇦Canada sseto
Can confirm patch #5 works on Drupal 9.5.2 and PHP 8.1.14.
Thank you for the patch!
Comment almost 2 years ago →
System Message

Sutharsan → committed c50b3d34 on 8.x-2.x
Issue #3281927 by Sutharsan, nsciacca: Error on node revision route due...
Status changed to Fixed almost 2 years ago10:31am 30 January 2023
Comment almost 2 years ago →
🇳🇱Netherlands sutharsan
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024