- π©πͺGermany Grevil
Just stumbled upon this issue, while trying to enable "extra_field_plus" through drush.
- Status changed to RTBC
over 1 year ago 7:20am 3 May 2023 - π©πͺGermany Grevil
I can confirm, that the patch by @emanuelrighetto fixes the problem!
- last update
over 1 year ago 41 pass - Status changed to Needs review
over 1 year ago 7:39am 3 May 2023 - π©πͺGermany Grevil
Please review! I added the required changes to the docs and fixed two tiny phpcs issues.
- Status changed to Needs work
over 1 year ago 3:44pm 30 May 2023 - πͺπΈSpain rodrigoaguilera Barcelona
Given the status of the 2.x branch of extra_field that only supports Drupal 9 and 10, the support for DCG v1 should be dropped too
https://github.com/Chi-teck/drupal-code-generator/
Drupal 7 and 8 are supported for DCG v1.Removing the service definitions and the classes will solve the problem in the title of this issue. I wouldn't complicate the code with a compiler pass. There needs to be a way for modules to provide generators for multiple version of DCG. If you are using drush 12 you will get DCG v3 as a dependency.
Then we have the problem of how to support v2 and v3 that was recently release since PluginGenerator is not on v3 anymore.
In trying to solve this issue I opened
https://github.com/drush-ops/drush/issues/5600
I haven't tried yet but a drush.services.yml might not be needed anymore and the generators can be autodiscovered like commands in drush 12. - last update
over 1 year ago 41 pass - @rodrigoaguilera opened merge request.
- Status changed to Needs review
over 1 year ago 4:09pm 30 May 2023 - πͺπΈSpain rodrigoaguilera Barcelona
Just opened a fresh MR in case the code on the first MR needs to be revisited for DCG v3 support.
I think removing DCG v1 support is simple and a direct way to solve this issue.I opened β¨ Add support for Drupal Code Generator version 3 (required for drush 12) Active to focus the efforts for v3
- First commit to issue fork.
- last update
over 1 year ago 41 pass - last update
over 1 year ago 41 pass - last update
over 1 year ago 41 pass - πΊπΈUnited States Greg Boggs Portland Oregon
here's a patch for the latest MR
- Status changed to RTBC
12 months ago 4:33pm 22 December 2023 - π¨π¦Canada maursilveira Windsor, ON
Patch from #18 works for me and fixes the error.
Thank you.