Undefined array key "tags" in MailchimpSignupPageForm

Same warning here too.

I've updated the merge request to use the `??` syntax, and uploaded a diff file in case needed in that format

@kimberleycgm, thanks for working on this. Uploading a patch is not needed, Gitlab provides it for you (the 'plain diff' link to https://git.drupalcode.org/project/mailchimp/-/merge_requests/46.diff)

fwiw, had the same issue and patch/mr fixed for me

Applied @Andy Price's suggested change from NULL to []

Looks good to me, thanks!

+1 RTBC

I've added test coverage for this issue. To get these tests to pass, some more fixes were needed for MailchimpSignupPageForm. That's because more variables are used without checking if they exist.

I set it back to "Needs review" because of the tests and the other changes.

I see now that the tests cannot be viewed in GitLab's UI. I think that's because there are special characters being used in saved mailchimp_signup configuration. On a mailchimp_signup config entity, on settings > mergefields > EMAIL, a serialized object gets saved. And this apparently results into a string with special characters when defining that serialized object as string in the test as follows (I removed the special chars from the code as else drupal.org couldn't save my comment properly either):

// Programmatically add a signup form with only required fields set.
MailchimpSignup::create([
  'title' => 'My signup form',
  'id' => 'my_signup_form',
  'mc_lists' => [
    '57afe96172' => '57afe96172',
  ],
  'mode' => MAILCHIMP_SIGNUP_BLOCK,
  'mergefields' => [
    'EMAIL' => TRUE,
  ],
  'settings' => [
    'submit_button' => 'Sign up',
    'mergefields' => [
      'EMAIL' => 'O:8:"stdClass":8:{s:3:"tag";s:5:"EMAIL";s:4:"name";O:48:"Drupal\Core\StringTranslation\TranslatableMarkup":3:{s:9:"*string";s:13:"Email Address";s:12:"*arguments";a:0:{}s:10:"*options";a:0:{}}s:4:"type";s:5:"email";s:8:"required";b:1;s:13:"default_value";s:0:"";s:6:"public";b:1;s:13:"display_order";i:1;s:7:"options";O:8:"stdClass":1:{s:4:"size";i:25;}}',
    ],
  ],
])->save();

It's kinda awful that serialized objects are saved as configuration. This could potentially lead to issues in future Drupal versions. For example when \Drupal\Core\StringTranslation\TranslatableMarkup would first be deprecated and then removed. Anyway, that would be something to be fixed in an other issue, though it does cause now to make the tests a lot harder to review.

Automatically closed - issue fixed for 2 weeks with no activity.