- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
@gaurav-mathur @Akhildev.cs appears screenshots were already in #34 so these were duplicated efforts unfortunately.
Hiding all the screenshot noise
Appears this was tagged for tests also which still need to happen.
I did not do a code review.
- 🇺🇸United States loze Los Angeles
What version of ckeditor is this supposed to work with? I do not see any edit button after applying the patch using ckedtor5
- 🇳🇿New Zealand ericgsmith
@loze that patch will not work with CKEditor5 as CKEditor5 does not load the form that it is altering.
I have added an MR to the edit_media_modal module with an approach for CKEditor 5 https://www.drupal.org/project/edit_media_modal/issues/3352274 ✨ Support CKEditor5 Needs review
- 🇪🇨Ecuador jwilson3
✨ Support CKEditor5 Needs review has been closed and marked fixed. Since this now has a working solution in contrib, should this issue re-focus efforts around inclusion of the functionality from https://www.drupal.org/project/edit_media_modal → into core's Media Library CKE5 integration?
- 🇪🇨Ecuador jwilson3
I found that there is work going on elsewhere for this, including:
- Another contrib module, that has also implemented a modal approach and has more installs than this module: https://www.drupal.org/project/media_library_edit →
- Core design issue: 📌 Design a UI to allow various kinds of alterations to referenced Media entities in a modal Active
- Core implementation issue: ✨ Allow media items to be edited in a modal when using the field widget Postponed