Contrib.social

Allow edit Media items from Media Library modal dialog in CKEditor

Open on Drupal.org →
Created on 3 September 2020, over 4 years ago
Updated 8 December 2023, about 1 year ago

Problem/Motivation

At now there are no ways to edit media, that was inserted into content, using Media Library CKEditor widget. So, if user, for example, want to change name of media item, or replace image to other - he have only long way via searching this media item in library on separate page manually, and edit it.

Steps to reproduce

1. Enable Media Library module, and in CKEditor add Media Library button.
2. In node edit form upload and insert some document file (eg "Exomple one.pdf") in CKEditor via "Add Media from Library" button.
3. See, that file name is bad, then try to find way for edit this media to change name of this media - In "Edit media" modal window you will see only align and other widget settings, but not fields of current media.

Proposed resolution

Allow Media items to be edited from modal dialog in CKEditor.

Remaining tasks

Finish patch, discuss scope.

User interface changes

Add link to media edit page.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
Media  →

Last updated 1 day ago

Created by

🇦🇲Armenia murz Yerevan, Armenia

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs accessibility review

    Used to alert the accessibility topic maintainer(s) that an issue significantly affects (or has the potential to affect) the accessibility of Drupal, and their signoff is needed (see the governance policy draft for more information). Useful links: Drupal's accessibility standards, the Drupal Core accessibility gate.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    @gaurav-mathur @Akhildev.cs appears screenshots were already in #34 so these were duplicated efforts unfortunately.

    Hiding all the screenshot noise

    Appears this was tagged for tests also which still need to happen.

    I did not do a code review.

  • Comment about 1 year ago →
    🇺🇸United States loze Los Angeles

    What version of ckeditor is this supposed to work with? I do not see any edit button after applying the patch using ckedtor5

  • Comment about 1 year ago →
    🇳🇿New Zealand ericgsmith

    @loze that patch will not work with CKEditor5 as CKEditor5 does not load the form that it is altering.

    I have added an MR to the edit_media_modal module with an approach for CKEditor 5 https://www.drupal.org/project/edit_media_modal/issues/3352274 ✨ Support CKEditor5 Needs review

  • Comment about 1 year ago →
    🇳🇿New Zealand ericgsmith
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024