Allow media items to be edited in a modal when using the field widget

Re-roll of #142 for Drupal 10.1.x.

#148 works for me, running Drupal 9.5.3 + Gin theme.

While there are other related issues that would be ideal to solve in core all with one solution, in the meantime I think the Media Library Edit contrib module is a great solution to this particular problem. It works very well, supports D10 and appears to be fairly actively maintained.

In a very specific scenario, when a media entity has more than a single 'file' type field (i.e.: 'book' media entity, containing a 'file' field and a 'cover' field) this patch causes the editing form to not submit properly when adding/removing the second 'file' type field (the user has to click on the 'Save' button twice, so that the changes take place).

I have added some extra lines to make sure that the media library opener is actually the 'Field widget'. This avoids the annoying issue I described above. This patch is based on #148.

I suppose it would not be advisable to get the basic functionality of the Media Library Edit → or the Media Library Media Modify → contrib module in Core until as phenaproxima mentioned in #109 there is ...

dedicated funding and time from the media team, UX team, and accessibility experts to come up with a version of this feature that would be suitable for core.

It definitely would be nice to have a Core solution but the patch in this issue is working for me.

As described in #157 I came across the same issue where we had to press the 'Save' button twice.
Patch #157 fixes this and works great for me.

@MiguelArber could we perhaps have #158 in the MR for easier review? Or as separate MR otherwise?

I opened MR !4517 with #157 ✨ Allow media items to be edited in a modal when using the field widget Postponed rebased on 11.x.

I am sorry for the delay, I just read the message posted by @Anybody, but I see that @dieterholvoet has already created an MR of the rebased #157. Please let me know if I can help on anything else.

PS: I'm glad to help, thanks for testing @Victornator.

patch #153 work with a Drupal 10.1.5

Updated the patch in comment #157 to work with 10.1, posting here in case anybody else needs it…

Apologies for the noise but am attaching another patch, #165 with a minor update: added an aria-label to the Edit button, in the same fashion as the one present on the Remove button.

This is getting confusing to work on. There's many patches, and two open merge requests. To keep this sane and easier to review, please let's stick to updating MR !4517 only.

I've updated it to reflect the changes #166 and made another minor fix for a PHP warning.

I also agree with comments above that this shouldn't really be postponed without a related issue that it's waiting on. Until we have that, setting this back to "Active". I acknowledge this issue isn't likely to get anywhere without involvement from the UX team, but having the issue set to Postponed doesn't seem that will make it any more likely to happen.

This is postponed on 📌 Design a UI to allow various kinds of alterations to referenced Media entities in a modal Active which is marked as a parent.

And it should be set to postponed because there's no point people working on this patch until a UI has been designed.

Thanks @joachim, missed that.

Note that I think the original merge request is what was split off into a module Media Library Media Modify → . This allows overrides of fields from the referenced media. AKA contextual edits. That functionality differs quite a bit from the latest patches/MR from this issue, which now just focus on presenting a simple edit button to edit the media item in a modal. Those changes affect the media everywhere it's used. It's simpler and I think has a much better chance of getting into core.

I hope we can agree to keep this issue focused on the simple use case.

> That functionality differs quite a bit from the latest patches/MR from this issue, which now just focus on presenting a simple edit button to edit the media item in a modal. Those changes affect the media everywhere it's used. It's simpler and I think has a much better chance of getting into core.

I agree that the override functionality is a bit specific.

But for core we need editability AND translation, which is two items. Overriding is just a third, but the need for a UI pattern is already there.

I created a patch for 10.2 based on the MR @bkosborne updated.

merged 11.x into !4517

Snapshot of latest state of MR for safe usage with composer-patches on drupal/core:11.1.1