I believe RTBC is the proper status for this…
Sorry, please disregard, Linkit wasn’t being patched properly in my local environment. Patch in #41 worked for me too.
Maybe I have a unique configuration, but the patch in #41 does not work for me.
Drupal 10.3.6
Linkit 6.1.4
CKEditor Anchor Link 3.0.0-beta1
When I go to save the link, either by selecting the matched node or tabbing out of the URL field, the anchor portion of the link (“#foo”) is stripped away.
byronveale → created an issue.
One last note, FWIW I also tried the patch with 7.0.0-alpha1, same results.
Enabled Xdebug, added a breakpoint to the added AnchorMatcher plugin, found that it was ignored when adding an anchor link (starting with “#”).
As a comparison test, added a breakpoint to the EmailMatcher plugin, which was not ignored when adding an email link.
Comparing the two plugins, I could not find any obvious reason why the AnchorMatcher would be ignored.
Tested the patch from #10 with Linkit 6.1.4 and found no difference in Linkit’s behavior. Instead of seeing the added “Links to an anchor named @anchor on the current page” message, saw the current “No content suggestions found. This URL will be used as is.” message.
+1 for getting this committed so we can use this module with Composer.
Attaching patch from merge request.
This works for me locally…
byronveale → created an issue.
Composer choked on patch generated from issue fork. Attaching new one that composer liked which was generated using patch utility.
Updated patch after fixing test.
I created a merge request where the “throbber” icons have been replaced with Claro’s magnifying glass icons. I also updated the helper text in an attempt to add clarity.
Attaching a patch generated from this merge request.
byronveale → created an issue.
We have the same issue, Drupal 10.2.6, Linkit 6.1.4.
Looks like the only way to create a link to an anchor in a page is to use the text editor’s “Source” button.
Whoops, closing this.
Okay, for anyone else who ends up here, this was fixed in issue #3328244 → . Use the latest version of migrate_upgrade, 4.0.1.
Got this same error, using:
- Drupal 10.1.8
- migrate_upgrade 4.0.0
- drush 12.4.3.0.
FYI, the code submitted to the related bibcite issue ✨ Add PubMed Central (PMC) field Fixed has been committed.
Also, we have been using this in Production on a platform with hundreds of sites for about a year now, so going out on a limb and marking this as RTBC.
This has been committed to 3.0.x branch, so, “fixed”?
Apologies for the noise but am attaching another patch, #165 with a minor update: added an aria-label to the Edit button, in the same fashion as the one present on the Remove button.
Updated the patch in comment #157 to work with 10.1, posting here in case anybody else needs it…
Edited the issue as further testing bore out the fact that adding the CAPTCHA element to a specific page in the Webform mitigates this issue. A user would only need to redo the reCAPTCHA if they navigated back to the page with the CAPTCHA.
So there is still an issue here as the Math challenge type behaves as expected, i.e. once completed, do not need to redo.
byronveale → created an issue.
As a first step towards adding this functionality, I have come up with some code that adds a PubMed Central (PMCID) field, and populates it when importing references using PubMed lookup.
The patch I am attaching works in conjunction with a patch I added to a related Bibcite issue ✨ Add PubMed Central (PMC) field Fixed .
A sample to test with is PMID 26996306.
Patch attached.
byronveale → created an issue.