- π§πͺBelgium kriboogh
Tested and works +1
Been 2 years, what is holding us back to get this in ? - Status changed to Needs review
10 months ago 12:36pm 12 September 2023 - πΊπΈUnited States mark_fullmer Tucson
Been 2 years, what is holding us back to get this in ?
Thanks for checking in on this. The previous maintainers of this module moved on to other things; I have taken over active maintainership since April 2023, and have been making my way through the backlog of nearly 200 issues. Since there had been no activity on this issue in 2 years, I hadn't yet seen it.
In principle I agree with the goal of this basic matcher: "Create a basic matcher for anchors that just takes anything that starts with "#" and tells people that it is an anchor."
This will need to be tested against the 6.x branch; active development is no longer happening in 8.x-5.x. I'll set the version number to 6.1.x and set it back to "Needs review." If someone can functionally test it against the 6.1.x branch and demonstrate that the automated test suite passes, that would be great.
- First commit to issue fork.
- last update
9 months ago 47 pass, 2 fail - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
9 months ago Not currently mergeable. - @sleitner opened merge request.
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
9 months ago Not currently mergeable. - last update
9 months ago 84 pass - Status changed to RTBC
9 months ago 11:50am 2 October 2023 - πΊπΈUnited States smustgrave
Tested patch #10 and doesn't appear to be working for us. Doesn't do a search.
- π¨π¦Canada kpaxman
As noted, this is just a basic matcher. It doesn't try to search existing anchors, it just assumes anything that starts with # is an anchor.
It could probably be extended to search anchors within an existing editor block, but I'm not sure how this would work in a field or in a layout builder environment when you have multiple blocks on a page, each potentially with anchors, not necessarily served by an editor.
- πΊπΈUnited States smustgrave
So what's the difference with β¨ Add better support for linking to anchors RTBC
- π¨π¦Canada kpaxman
While noting that it's been years since I wrote this, at a glance I would say the difference is that this tackles the first bullet point from that other ticket, which from what I can tell the other one makes no attempt to solve. This patch makes no effort to solve the other bullet point, which *does* seem to be getting solved in the other ticket.