Add a basic matcher for anchors

Tested and works +1
Been 2 years, what is holding us back to get this in ?

Been 2 years, what is holding us back to get this in ?

Thanks for checking in on this. The previous maintainers of this module moved on to other things; I have taken over active maintainership since April 2023, and have been making my way through the backlog of nearly 200 issues. Since there had been no activity on this issue in 2 years, I hadn't yet seen it.

In principle I agree with the goal of this basic matcher: "Create a basic matcher for anchors that just takes anything that starts with "#" and tells people that it is an anchor."

This will need to be tested against the 6.x branch; active development is no longer happening in 8.x-5.x. I'll set the version number to 6.1.x and set it back to "Needs review." If someone can functionally test it against the 6.1.x branch and demonstrate that the automated test suite passes, that would be great.

Tested and works fine.

Tested patch #10 and doesn't appear to be working for us. Doesn't do a search.

As noted, this is just a basic matcher. It doesn't try to search existing anchors, it just assumes anything that starts with # is an anchor.

It could probably be extended to search anchors within an existing editor block, but I'm not sure how this would work in a field or in a layout builder environment when you have multiple blocks on a page, each potentially with anchors, not necessarily served by an editor.

So what's the difference with ✨ Add better support for linking to anchors Postponed: needs info

While noting that it's been years since I wrote this, at a glance I would say the difference is that this tackles the first bullet point from that other ticket, which from what I can tell the other one makes no attempt to solve. This patch makes no effort to solve the other bullet point, which *does* seem to be getting solved in the other ticket.

Tested the patch from #10 with Linkit 6.1.4 and found no difference in Linkit’s behavior. Instead of seeing the added “Links to an anchor named @anchor on the current page” message, saw the current “No content suggestions found. This URL will be used as is.” message.

Enabled Xdebug, added a breakpoint to the added AnchorMatcher plugin, found that it was ignored when adding an anchor link (starting with “#”).

As a comparison test, added a breakpoint to the EmailMatcher plugin, which was not ignored when adding an email link.

Comparing the two plugins, I could not find any obvious reason why the AnchorMatcher would be ignored.

One last note, FWIW I also tried the patch with 7.0.0-alpha1, same results.