Another field_group plugin was blocking the update not field_group_as_class
sleitner → created an issue.
Functional tests are green with Drupal 11 and Field_group 4.0.0
sleitner → created an issue.
sleitner → created an issue.
I could reproduce it locally. It was a problem on top of the timezone problem with the mapping of the current date to the dates in the pager. Please test and review 🐛 Paging seems to be done using UTC and not local time zone. Active
Now fixes the problem with some special dates e.g. March 31th, please review
Could you reproduce this on a new Drupal installation, e.g. on simplytest.me ? Do you patch something in date_pager? Or Javascript changing content in frontend? What is the URL in the false 05 link?
I couldn't reproduce it with the steps given above on simplytest.me.
Any idea how to test the fallback to symfony/polyfill-intl-icu ?
I think this is also UTC / local time zone related
Please review the related issue
sleitner → made their first commit to this issue’s fork.
sleitner → made their first commit to this issue’s fork.
@kkonuhov: Any news on this update? When can we expect a D11 compatible tagged version?
@daften, @nick_vh, @nielsaers, @reszli: Any news on this update? When can we expect a D11 compatible tagged version?
sleitner → created an issue.
@rené bakx : Any news on this update? When can we expect a D11 compatible tagged version?
I'm not 100% sure, but I think that the reason for this is that all dates are handled as UTC in date_pager . German summer time is +2
@dark05 I think you have to take a look at https://github.com/mglaman/composer-drupal-lenient/
That is normal behavoir. The patch does not update metadata in composer or packigist, which composer update uses.
@acbramley : Test manually or automatically? Manually: "View live preview" via Tugboat next to the MR on the top of this issue page. In the tugboat PHP intl extension is not installed, at the moment. Same in Simplytest.me
@bnjmnm, @davidhernandez, @lauriii : Please release a new tagged version which is Drupal 11 compatible
Fixed the problem in MR11697 and tested it here in tugboat. Please review.
It turned out that my intl free test environment had still intl installed.
Tested the patch against 11.x manually on simplytest.me (where 11.x fails without patch) . Please review
sleitner → created an issue.
Rebased. What else needs to be done before the merge?
Please review MR
sleitner → made their first commit to this issue’s fork.
The date range was set too late, after the filter was applied. Please review the MR
@phjou , I could reproduce the issue
Rerolled
Did you try the latest MR? The attached patches are outdated.
joachim namyslo → credited sleitner → .
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Please release a new tagged version, which is Drupal 11 compatible.
sleitner → created an issue.
Please merge and release a taggged version
sleitner → made their first commit to this issue’s fork.
I cannot reproduce this behaviour with a clean website (with https://simplytest.me/). "Access denied" when accessing a non-current revision.
Rerolled
Your code only worked if the date field was already a view filter or field. If you use another format, it fails.
Please test MR10
@guietc and @julien' Any news on releasing a tagged Drupal 11 version?
@vasyok the tests are failing https://git.drupalcode.org/project/date_pager/-/jobs/4477490 . Needs test coverage for filter usage.
Any news on this update? When can we expect a D11 compatible tagged version?
The issue should be fixed in the Development version: 2.1.x-dev , see issue #3505261
Tests needed
sleitner → made their first commit to this issue’s fork.
Fixes issue Existing fields of date type 'daterange' are not matched as well
sleitner → made their first commit to this issue’s fork.
sleitner → created an issue.
@longwave you pointed in #31 about calling services inside the sort callback "is not going to be very performant in a case when there are hundreds of items or more to sort". The solution is to place the service outside the compare function sort().
Furthermore the function sort() name does not reflect its function. It is just comparing the two values, it is not sorting anything.
The merge conflict is resolved.
Thank you @kate heinlein
sleitner → created an issue.
sleitner → made their first commit to this issue’s fork.
sleitner → made their first commit to this issue’s fork.
sleitner → changed the visibility of the branch 1.0.x to hidden.
sleitner → made their first commit to this issue’s fork.
Added patch #7 to MR!5 , please review. phpunit test fails because theme namein this issue is classy-3461089 and not classy
sleitner → made their first commit to this issue’s fork.