Account created on 28 January 2013, over 12 years ago
#

Merge Requests

More

Recent comments

🇩🇪Germany sleitner

The MR doesn't fix the problem when installing/uninstalling modules which only add a sub menu item e.g. "User interface translation" for locale module.

The keys of the array do not change, so the hash does not change either. Maybe the installed modules list should be in in the hash input, too?

🇩🇪Germany sleitner

Rerolled, added context in several cases, added default to config and added default to tests

🇩🇪Germany sleitner

sleitner made their first commit to this issue’s fork.

🇩🇪Germany sleitner

The PHP intl extension is compiled into PHP in the docker image. If the PHP intl extension should be optional, the base docker image has to be changed to install intl with pecl.

I compared the composer.json ext-* requirements and the extensions installed in the gitlab docker image. There are many PHP extensions installed that are not listed as required by core and its dependencies. Doesn't this lead to potential post-installation problems on systems that don't have the usual large number of PHP extensions installed? If the PHP extensions are only suggested,, they should be disableable for testing.

🇩🇪Germany sleitner

I don’t think we need to do anything in the templates for this case. Hopefully the above links will help you achieve what you need.

An automated test for both cases is a precondition for the merge of this kind of core issue. Maybe an addional image is necessary for the additional test.

🇩🇪Germany sleitner

I don't think it's necessary because drupal/core is a dependency, but maybe better safe than sorry.

🇩🇪Germany sleitner

sleitner changed the visibility of the branch 3532187-composer-issue-when to hidden.

🇩🇪Germany sleitner

I wonder when (root)/composer.json for drupal/drupal is involved in install or update? I still have the problem that phpcodesniffer-composer-installer 1.1.0 is installed when updating to drupal 10.5.1 with composer.

Shouldn't the conflict setting be placed in core/composer.json for drupal/core?

🇩🇪Germany sleitner

Users may set their own time zone OFF does not mean that the website timezone is used, the users simply cannot change the settings via UI. I assume there was a different timezone set. Now the user time zone defaults to website timezone if user timezone is not configurable. Please review MR

🇩🇪Germany sleitner

Breaks all my sites. Only workaround is go back to 10.4.8 or 11.1.8

🇩🇪Germany sleitner

Any news on this update? When can we expect a D11 compatible tagged version?

🇩🇪Germany sleitner

@vasyok : I cannot reproduce this issue, if I set the time manually to 31.3.2025. Which system timezone and user timezone are you using? Which field type is your date field?

🇩🇪Germany sleitner

@leon kessler , @rodrigoaguilera : any news on this issue?

🇩🇪Germany sleitner

Another field_group plugin was blocking the update not field_group_as_class

🇩🇪Germany sleitner

Functional tests are green with Drupal 11 and Field_group 4.0.0

🇩🇪Germany sleitner

I could reproduce it locally. It was a problem on top of the timezone problem with the mapping of the current date to the dates in the pager. Please test and review 🐛 Paging seems to be done using UTC and not local time zone. Active

🇩🇪Germany sleitner

Now fixes the problem with some special dates e.g. March 31th, please review

🇩🇪Germany sleitner

Could you reproduce this on a new Drupal installation, e.g. on simplytest.me ? Do you patch something in date_pager? Or Javascript changing content in frontend? What is the URL in the false 05 link?
I couldn't reproduce it with the steps given above on simplytest.me.

🇩🇪Germany sleitner

Any idea how to test the fallback to symfony/polyfill-intl-icu ?

🇩🇪Germany sleitner

@kkonuhov: Any news on this update? When can we expect a D11 compatible tagged version?

🇩🇪Germany sleitner

@daften, @nick_vh, @nielsaers, @reszli: Any news on this update? When can we expect a D11 compatible tagged version?

🇩🇪Germany sleitner

@rené bakx : Any news on this update? When can we expect a D11 compatible tagged version?

🇩🇪Germany sleitner

I'm not 100% sure, but I think that the reason for this is that all dates are handled as UTC in date_pager . German summer time is +2

🇩🇪Germany sleitner

That is normal behavoir. The patch does not update metadata in composer or packigist, which composer update uses.

🇩🇪Germany sleitner

@acbramley : Test manually or automatically? Manually: "View live preview" via Tugboat next to the MR on the top of this issue page. In the tugboat PHP intl extension is not installed, at the moment. Same in Simplytest.me

🇩🇪Germany sleitner

@bnjmnm, @davidhernandez, @lauriii : Please release a new tagged version which is Drupal 11 compatible

🇩🇪Germany sleitner

Fixed the problem in MR11697 and tested it here in tugboat. Please review.

🇩🇪Germany sleitner

It turned out that my intl free test environment had still intl installed.

Tested the patch against 11.x manually on simplytest.me (where 11.x fails without patch) . Please review

🇩🇪Germany sleitner

Rebased. What else needs to be done before the merge?

🇩🇪Germany sleitner

The date range was set too late, after the filter was applied. Please review the MR

🇩🇪Germany sleitner

Did you try the latest MR? The attached patches are outdated.

Production build 0.71.5 2024