Reroll and some fixes
sleitner → made their first commit to this issue’s fork.
Rerolled again
sleitner → created an issue.
sleitner → created an issue.
sleitner → created an issue.
Duplicate of 🐛 Javascript warning from content language and translation page Fixed
I think this is a duplicate of 🐛 Javascript warning from content language and translation page Fixed . It is fixed in 10.3.x-dev
Patch #9 works for me
Converted to MR
Unpostpone it. 🐛 Country list is not correctly sorted when it's localized with accents (e.g. German, Turkish) Postponed is postponed because nobody wants to break the API.
per #2 and #3
I tried to build a test for this issue following the steps in the summary. I must be missing something, because the test doesn't fail as expected. See test file attached.
@i.mcbride your regular expression does not match the user URL.
The patch includes a new regex and test coverage.
sleitner → made their first commit to this issue’s fork.
The problem was solved: 🐛 Content language and translation AJAX expansion is backwards Fixed
Rerolled to 11.x in new branch in MR 6727
sleitner → made their first commit to this issue’s fork.
Is a duplicate of 🐛 Status of checkboxes on content translation admin page having wrong status Needs work
The detail fields are invisible as soon as the content type is activated.
JS error:
Uncaught TypeError: $element[0] is undefined
Workaround: deactivate the content type translation and reactivate it and set the field settings before saving.
I don't know why this is not a local variable. But since it only reads the request, a clone is not necessary.
The Content Translation permission settings changed since Drupal7. In Drupal 10 the permissions are more granular.
This is already fixed: 🐛 Put each entity type table into a details element on admin/config/regional/content-language Fixed
Everything you are translating with |t, t(), TranslatableMarkup is translated with the current interface language.
Look in /admin/config/regional/language/detection how the interface language is negotiated. If you have custom language negotiators installed or custom settings in settings.php or simular, these might interfere your interface language as well.
The config language , content language and url language are independent from this and have their own negotiators.
If you set the config language with setConfigOverrideLanguage(), you only change the config language for reading and writing to the translated config settings
https://www.drupal.org/docs/drupal-apis/configuration-api/simple-configu... →
sleitner → made their first commit to this issue’s fork.
X-Drupal-Cache is now always present. It is MISS for the first access and HIT for further accesses.
Width and height is managed by video_embed_field. Use the Responsive Video option in the manage display settings of the field.
core/tests/Drupal/KernelTests/Config/DefaultConfigTest.php did fail because path alias is not available when locale is installed. Instead of the route to url conversion, the url is now hardcoded.
I fixed the visibility of the modules variable of the test. Drupal\Tests\language\Functional\LanguageBrowserDetectionAcceptLanguageTest still fails.
Now it's all green
/scripts-127385-579080/step_script: line 272: /usr/bin/tr: Argument list too long
/scripts-127385-579080/step_script: line 272: /usr/bin/yarn: Argument list too long
No, that is a GitlabCI problem. When many files are changed (during reroll), the spell-checking job always fails.
I tested this again, but there is no error anymore. Should we close it as outdated?
It seems to me that we have to delegate this to the custom modules as long as we do not want to break anything.
In the country module ✨ Sort country names using Collator Fixed the country lists are now sorted correctly. It does not cover the default country settings in the core regional settings.
"Distinct: on" should be the default, to be sure!?
It is running: https://git.drupalcode.org/project/country/-/pipelines
It runs automated tests in the Drupal GitLab CI whenever changes are mode to the code, or whenever a contributor submits a merge request.
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
As soon as Unit, Kernel or Functional tests are added, these are executed as well:
https://www.drupal.org/docs/develop/automated-testing →
message and url are updated following the recommendations.
sleitner → created an issue.
public function getList() in CountryFieldManager should not be removed as long as it is used.
Reroll for current dev version.
For the correct sorting please replace
$element['#options'] = \Drupal::service('country_manager')->getList();
with this
$element['#options'] = \Drupal::service('country.field.manager')->getList();
Configuration Inspector → shows errors in the configuration for the country settings, if this is used in a view.
Do you have the problem without using \Drupal::languageManager()->setConfigOverrideLanguage()?
@Chris64: 1) $return = $translated_array[1]; was in line 136 in 2017
2) I separated the singular form completely from the plural forms:
$index = $this->getPluralIndex();
// Singular form.
if ($this->count == 1 || $index == 0 || count($translated_array) == 1) {
return $this->placeholderFormat($translated_array[0], $arguments);
}
// N-th plural form, fallback to second plural form.
$return = $translated_array[$index] ?? $translated_array[1];
sleitner → changed the visibility of the branch 3219537-languagenegotiationurlprocessoutbound-modifies-absolute to hidden.
sleitner → made their first commit to this issue’s fork.
sleitner → made their first commit to this issue’s fork.
setConfigOverrideLanguage does only change the config language. It doesn't change the interface and content language.
I'm not sure if it helps for the update from 0.3.0 to 0.4.0, but it should help for future updates
sleitner → created an issue.
Hi Libbna, the session lifetime is not set by this module. It logs in as a normal user with normal parameters.
You have to adjust the session parameters in /sites/default/services.yml
The country is also needed for the date format, because the e.g the month names may differ between countries with the same language:
January in German German is Januar, but in Austrian German it is Jänner
@Gogowitsch, @greg.harvey, @hoanns, @kbahey, @McChicken, @instanceofjamie please release an new tagged version to restore funktioniality.
sleitner → created an issue.
Please review. If the automated tests had worked, this would have been noticed during the test.
sleitner → created an issue.