Fixed the problem in MR11697 and tested it here in tugboat. Please review.
It turned out that my intl free test environment had still intl installed.
Tested the patch against 11.x manually on simplytest.me (where 11.x fails without patch) . Please review
sleitner → created an issue.
Rebased. What else needs to be done before the merge?
Please review MR
sleitner → made their first commit to this issue’s fork.
The date range was set too late, after the filter was applied. Please review the MR
@phjou , I could reproduce the issue
Rerolled
Did you try the latest MR? The attached patches are outdated.
joachim namyslo → credited sleitner → .
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Duplicate of #3433824
Please release a new tagged version, which is Drupal 11 compatible.
sleitner → created an issue.
Please merge and release a taggged version
sleitner → made their first commit to this issue’s fork.
I cannot reproduce this behaviour with a clean website (with https://simplytest.me/). "Access denied" when accessing a non-current revision.
Rerolled
Your code only worked if the date field was already a view filter or field. If you use another format, it fails.
Please test MR10
@guietc and @julien' Any news on releasing a tagged Drupal 11 version?
@vasyok the tests are failing https://git.drupalcode.org/project/date_pager/-/jobs/4477490 . Needs test coverage for filter usage.
Any news on this update? When can we expect a D11 compatible tagged version?
The issue should be fixed in the Development version: 2.1.x-dev , see issue #3505261
Tests needed
sleitner → made their first commit to this issue’s fork.
Fixes issue Existing fields of date type 'daterange' are not matched
as well
sleitner → made their first commit to this issue’s fork.
sleitner → created an issue.
@longwave you pointed in #31 about calling services inside the sort callback "is not going to be very performant in a case when there are hundreds of items or more to sort". The solution is to place the service outside the compare function sort()
.
Furthermore the function sort()
name does not reflect its function. It is just comparing the two values, it is not sorting anything.
The merge conflict is resolved.
Thank you @kate heinlein
sleitner → created an issue.
sleitner → made their first commit to this issue’s fork.
sleitner → made their first commit to this issue’s fork.
sleitner → changed the visibility of the branch 1.0.x to hidden.
sleitner → made their first commit to this issue’s fork.
Added patch #7 to MR!5 , please review. phpunit test fails because theme namein this issue is classy-3461089 and not classy
sleitner → made their first commit to this issue’s fork.
Version 2.2.0-alpha1 released
Works for me
sleitner → created an issue.
ToolbarAdminMenuTest
test still needs to be updated
sleitner → changed the visibility of the branch 11.x to hidden.
sleitner → made their first commit to this issue’s fork.
If there are new information, please reopen the issue
There are 2 error in your status, you should solve these first. Depending on the number of nodes/entities, 256MByte memory may be too few.
@larowlan all references to 11.1 are replaced by 11.2
Any news on this issue?
Rebased
Rebased
@adcillc @adci_contributor, any news on a Drupal 11 compatible tagged version?
@j_s MR10 is now against 2.0.x
@j_s I renamed the temporary column, please try MR9