- Issue created by @sleitner
- 🇬🇧United Kingdom scott_euser
Thanks for raising! I think I might need more steps to reproduce that; it seems like the proposed MR is masking a problem uncompressing the stored data?
What is the value from this $json here? (ie, just before the code you are adding).
```
$json = UrlHelper::uncompressQueryParameter($viewsreference['compressed']);
``` - 🇬🇧United Kingdom scott_euser
And steps to reproduce please. Need to understand why compress/uncompress isn't working for you. Is it compressing null in the first place or is it failing to uncompress. Your link in steps to reproduce isn't sufficient to actually reproduce
- 🇩🇪Germany sleitner
Someone who tries many SQL injections on my website causes hundreds of errors in the logs.
The viewsreference[compressed] URL parameter is not compressed and not JSON.
PHP Version is 8.2.25Since
null
orint
is not specified in the interface ofViewsReferenceCompressionInterface
as a valid return value
public function uncompress(array $viewsreference, ViewExecutable $view): array;
Therefor a TypeError error is thrown and causes a php error in the drupal log/admin/reports/dblog
and an error in the apache error logs - 🇬🇧United Kingdom scott_euser
Thanks for the details and patience helping me understand. Added test coverage that fails without the code change + passes with the code change. Thank you!
-
scott_euser →
committed 1b512665 on 8.x-2.x authored by
sleitner →
Issue #3489155 by sleitner, scott_euser: uncompress(): Return value must...
-
scott_euser →
committed 1b512665 on 8.x-2.x authored by
sleitner →