Remove service location anti-patterns in constructors: jsonapi

Created on 27 May 2023, about 1 year ago

Updated 29 May 2023, about 1 year ago

@mglaman pointed out the possible problem of these three patterns in the class constructor in his blog:
$this->request = $request_stack->getCurrentRequest();
$this->nodeStorage = $entity_type_manager->getStorage('node');
$this->config = $config_factory->get('mymodule.settings');

the following classes are affected:
Drupal\jsonapi\Routing\ReadOnlyModeMethodFilter

📌 Task

Status

Needs work

Version

11.0 🔥

Component

JSON API →

Last updated 2 days ago

Maintained by
@e0ipso
🇳🇱Netherlands @bbrala
🇫🇷France @gabesullice
🇧🇪Belgium @Wim Leers

Created by

🇩🇪Germany sleitner

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Comments & Activities

Issue created by @sleitner
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
29,401 pass
@sleitner opened merge request.
Issue was unassigned.
Status changed to Needs review about 1 year ago8:22pm 28 May 2023
Comment about 1 year ago →
🇩🇪Germany sleitner
Status changed to Needs work about 1 year ago2:48pm 29 May 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Think the issue summary should be updated using the default template

What article?
Why is this a problem?
How does this make things better?

Should be included as part of the issue summary.

Also why breakup across tickets vs 1?

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024