- last update
over 1 year ago 30,332 pass, 1 fail - Status changed to Needs review
about 1 year ago 5:52pm 20 March 2024 - Status changed to Needs work
about 1 year ago 6:00pm 20 March 2024 - 🇺🇸United States smustgrave
Will need test coverage showing the problem.
Issue summary is also incomplete, recommend using the standard issue template
- 🇳🇱Netherlands neograph734 Netherlands
I have updated the IS and merged it with the content of 🐛 Toolbar causes a Javascript error if the subtrees content changes between page loads Closed: duplicate .
The patch from #2 and #9 does not appear to work. It makes the issue go away, but when a new module is installed, the menu does not update and the new links don't become visible. So the hash might be too generic(?).
The patch from #13 removes the has check alltogether. Without knowing what it is supposed to do, that feels too big of change.
Should we perhaps try hasing the raw menu tree structure or something instead?
- 🇧🇪Belgium matthiasm11
Combining the patches from #9 to generate the hash and #13 to fix the caching seems to fix the issue.
Disabling a module makes the corresponding menu item disappear, enabling the module again makes it appear again.
No console errors anymore. I've not investigated this any further. - 🇨🇿Czech Republic milos.kroulik
I can confirm observations made in #17. So I'm going to create a combined patch.
- 🇫🇷France ericdsd France
Hi milos.kroulik, did you create a combine patch for it yet ?
Note i'm still experiencing it on core 10.3.11.
- First commit to issue fork.
- 🇩🇪Germany sleitner
sleitner → changed the visibility of the branch 11.x to hidden.
- Merge request !10978Issue #3130197: Faulty toolbar subtree hash breaks asynchonous loading of admin menu content → (Open) created by sleitner
- 🇦🇷Argentina anairamzap Buenos Aires
I've created a patch that merges the ones in #9 and #13 based on core 10.3.x
Leaving this as "Needs work" since a test update is still missing
- 🇳🇱Netherlands frontmobe Amsterdam
Thanks @anairamzap, I can confirm that your patch also cleanly applies to Drupal 10.4.3.
- 🇪🇸Spain Carlos Romero
carlos romero → made their first commit to this issue’s fork.
- Merge request !11753Validate toolbar subtrees hash in AJAX responses → (Open) created by Carlos Romero
- 🇪🇸Spain Carlos Romero
Hi, I've forked, applied the change to the 10.4.x branch, and submitted the PR.
Best regards.
- 🇺🇸United States smustgrave
Have not reviewed but changes need to be against 11.x as that’s the development branch
- 🇳🇱Netherlands tinto Amsterdam
Rebased to 11.x
Greetings from the contrib room at Drupal Developer Days 2025 in Leuven, Belgium.
- 🇺🇸United States smustgrave
Hello!
New parameter probably should be typehinted and parameter doc added
Also will most likely need test coverage