🇨🇿Czech Republic @milos.kroulik

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

The very basic version in MR works, but it's entirely non-configurable and dependent on assumptions. Further work is needed.

milos.kroulik → made their first commit to this issue’s fork.

Explain default prop value in more detail.

There's at least one more use case where component CSS and JS files aren't imported - when the component is included (or embeded) in views fields that support twig. Perhaps it would be good to mention, but it's the SDC issue, not something specific to radix.

I think that the missing piece is how to add a component into an HTML textarea using the WYSIWYG.

This could be addressed by https://www.drupal.org/project/embedded_content_sdc → , unfortunately, the development is not very active lately.

page-navigation component is fixed, others should be checked and modified as needed.

milos.kroulik → created an issue.

Unfortunately, the patch from #27 doesn't seem to be working for me, as the "sub-widget" still doesn't allow SVG.

Based on the patch in #6 it looks like this is actually a duplicate of https://www.drupal.org/project/menu_link_attributes/issues/3331630 🐛 Compatibility with other modules, options being overwritten. Fixed , which is already RTBC. Can we close this one?

milos.kroulik → made their first commit to this issue’s fork.

The basic form of MR is submitted, it works for my use case.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

Thanks a lot. Just today I learned that there are cases when no container should be set (https://getbootstrap.com/docs/5.3/layout/gutters/#no-gutters).

milos.kroulik → created an issue.

Can you provide up-to-date instructions, how to make things work with Drupal 10, please? After applying the latest patch I went through docs at https://www.drupal.org/docs/contributed-modules/image-replace/integratio... → , but when I upload a new image using the media library, there's no way to select alternative images during the second step, like I can see at https://www.drupal.org/project/image_replace/issues/3048691#comment-1390... ✨ Support core media module Fixed

I will try to reproduce the issue on a completely new installation when I have a bit of time.

milos.kroulik → created an issue.

milos.kroulik → made their first commit to this issue’s fork.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

Rate your excitement about SDC in core: 1 ... 10 | N/A

10

Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A

10
I'm thinking of https://www.drupal.org/project/ui_patterns → 2.x here

Rate our documentation: 1 ... 10 | N/A

N/A Didn't read enough, yet.

Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2

2
I chose a theme (Radix 6.x) because of that

Rate the helpfulness of error messages encountered: 1 ... 10 | N/A

6
I have a limited experience here - the error message helped me fix the issue quickly, but then it turned out that there's probably a better way to do that fix.

Have you tried the Storybook integration? Yes | No

No
It still looks like a non-straightforward procedure for the time being.

Any thoughts you would like to share? The sky is the limit

Thanks you. I really hope that SDCs can help us find front-end developers willing to work with Drupal even in non-decoupled manner.

It looks like it doesn't work without specifying event name for SectionBuildRenderArrayEvent (at least in Drupal 10.2), such as

  const SECTION_BUILD_RENDER_ARRAY = 'section.build.render_array';

I will update the MR shortly based on this.

The CSS approach for the MR is not the way moving forward

Sorry, is there any developer documentation I can study to do better next time?

having !important for anything should be a last resort

I know, I used it purely because Bootstrap uses it for text-muted class and I don't know how to handle it differently.

I tried to fix the found issue. I will re-activate issue, if I will find something else.

I've created a MR with the fix described above, the only difference is that label_display is set to expected value visible.

The issue seems to be no longer present with the new subtheme generated from the latest commit.

It looks like you're right. The issue seems to be no longer present with the new subtheme generated from the latest commit. Thanks a lot.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

Oh, you're right, sorry. Perhaps this is solved, then. Thanks.

I can confirm the issue. Using the latest version of LB+ and Olivero theme, these errors prevent adding a block. In my case, the error messages are:

Warning: Undefined array key "layout_plugin" in Drupal\lb_plus\Controller\DropZones->getSection() (line 386 of /app/web/modules/contrib/lb_plus/src/Controller/DropZones.php)

InvalidArgumentException: Please configure a default layout for this section. in Drupal\lb_plus\Controller\DropZones->placeBlock() (line 185 of /app/web/modules/contrib/lb_plus/src/Controller/DropZones.php).

Please see the attached screencast at https://www.drupal.org/files/issues/2024-02-05/Recording%202024-02-05%20... →

Just a note - the latest state of MR seems to be applying cleanly to 10.2.x (which isn't the case with patches above it).

I've added a new MR containing just a fix for the issue mentioned above which means it should be easily mergeable to branch 2.0.x

Thanks a lot, I'm going to review the code, but right now I suppose that the initial goal is to be be able to:

• select the SDC component using plugin selector provided by https://www.drupal.org/project/cl_editorial → and fill values for props
• render the component in the CKeditor and in the actual rendered content

Is this generally true? Do you think it makes sense to contribute during this phase, or help with testing (and possibly coding) afterwards?

Thanks. But it looks like it's an empty repository. I also don't understand why this integration is a separate D.o project and not a part (or possibly a submodule) of embedded_content.

I would like to help this done, as we would like to use SDC-based embedded content on our new site. Can you specify your idea of this integration in a bit more detail, so it's clear what needs to be done, please?

milos.kroulik → created an issue.

I've tried to fix minor issues. Hopefully it makes sense.

Closed as a duplicate of https://www.drupal.org/project/plugin/issues/2647312 🐛 Use SubFormState in plugin selectors RTBC per comment above.

milos.kroulik → made their first commit to this issue’s fork.

milos.kroulik → created an issue.

First of all, this probably doesn't belong here.

Anyway, the solution in https://www.drupal.org/project/entity_print/issues/3136298#comment-13843190 💬 Print webform element in twig template file Active doesn't work now, because $variables['content'] contains only already rendered HTML. But in the same preprocess, there's actually a $webform_submission variable available.

milos.kroulik → created an issue.

It looks like there's a tradeoff - either you can generate images based on a static configuration (increases in viewport width), like responsive_image_automatic does or you need to use a JS to scale the image based on the dimensions of the container.

But I wonder, if it would make sense to generate the image styles and responsive image mappings automatically based on a "template" image style (which could for example define the webp conversion) and the theme.breakpoints.yml file.

There's also another module - https://www.drupal.org/project/drimage → , that seems to be very similar to https://www.drupal.org/project/easy_responsive_images: →

• it needs a JS code to work
• it integrates with focal_point and imageapi_optimize_webp

But it provides an image field formatter, which makes the setup very quick.

I've done some basic testing - it seems to be working fine on the frontend, but JS file is currently not loading in the CKeditor ( https://www.drupal.org/project/drimage/issues/3079190 ✨ embeds in wysiwyg not displaying media Closed: works as designed - but it looks like there's some workaround).

milos.kroulik → created an issue.

Thanks for the research. I've updated responsive_image_automatic module so I can test it in Drupal 10.1: https://github.com/miloskroulik/responsive_image_automatic.

Apart from missing multipliers, it (probably obviously) doesn't support lazy-loading of responsive images, which has been introduced in D 10.1 → .

I tried to look into JS code a bit to see why the editor preview is not generating. So far it looks like this.editor.model.change((writer) callback is not executed for the media plugin (it is for other plugins).

milos.kroulik → made their first commit to this issue’s fork.

I don't see any review here...

Just out of curiosity, I've tried to use a simple number widget instead of media selector, which works fine. So perhaps this should be solved in https://www.drupal.org/project/media_library_form_element → module queue?

It looks like this may be a bug, after all.

When I look at the XHR requests done while embedding the media entity, the last one looks like this.

But with styled list (provided by the examples module), there are some differences:

• there is an "update_build_id" command, which is missing when I'm embedding media
• there is a GET request, which returns rendered HTML

By debugging the EmbeddedContentDialogForm::ajaxSubmitForm method, I discovered, that update_build_id command is missing, because in \Drupal\Core\Form\FormAjaxResponseBuilder::buildResponse $form['#build_id_old'] is the same as $form['#build_id'] when I'm submitting form related to my media embedded content plugin (see above).

Of course, this might not be a true issue here...

I'm having the same issue. Just as an example, I've tried to create a sample module (https://github.com/miloskroulik/ckeditor5_embedded_content_media). I tend to believe the issue is in the way the render array gets rendered - will investigate later on.

milos.kroulik → created an issue.

The submitted MR:

• adds the redirection to created / updated entity on webform submission
• allows to specify a status message, that should be displayed to the user once he/she lands on the created/updated content entity

Other content entities besides nodes can be created, this should be reflected in the issue title.

milos.kroulik → made their first commit to this issue’s fork.

It looks like the MR is basically working, but when the inserted div is edited again, class (and possibly other attributes which I haven't tested) are missing. When editing existing div, the UI appears only on button click, which is different from other similar modules, which generally use contextual menu above the respective element (but this is a small issue, I would say).

labels are not required due to Bootstrap also not providing labels for columns

That's true, maybe they should be configurable?

module ... is not using any type of framework like Bootstrap

I believe this doesn't matter in this case, since I'm proposing an enhancement of editor interface for the grid.

It looks like the patch from #3 no longer applies:

$ patch -p1 < allow-stacked-modals.patch 
patching file src/Form/EmbeddedContentDialogForm.php
Hunk #1 FAILED at 80.
Hunk #2 succeeded at 189 (offset -4 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/Form/EmbeddedContentDialogForm.php.rej

It looks like there should be a note on the project page, that nested modals issue currently can't be solved.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → made their first commit to this issue’s fork.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

milos.kroulik → created an issue.

MR added

milos.kroulik → created an issue.