- 🇦🇹Austria hudri Austria
I don't think comment #24 covers the root problem: Do we need to inherit from the core image module or from the svg_image module? Creating a base widget surely is a good idea, but it just move the same problem to a different file.
But I think I've found the proper way to dynamically react on the existance of the svg_image module: hook_element_plugin_alter ( change record → , API doc)
It was explicitly designed to change the plugin class on runtime, exactly what is needed here. However, I still think we should wait for the other issue with the standalone form element.
- last update
10 months ago Patch Failed to Apply - 🇸🇦Saudi Arabia mesharideb
This patch enhances the Drupal Focal Point module to handle SVG images. It introduces a dependency on the SVG Image module and modifies the FocalPointImageWidget to extend from SvgImageWidget instead of ImageWidget. Additionally, it adds a condition to check if the image is an SVG. If it is, the function returns an empty array, bypassing the focal point functionality which is not applicable to SVG images.
- 🇨🇿Czech Republic milos.kroulik
Unfortunately, the patch from #27 doesn't seem to be working for me, as the "sub-widget" still doesn't allow SVG.
- 🇨🇦Canada SKAUGHT
IMO: this should be at least it's own submodule to focal_point, it not it's own project. the dependency to svg_field is heavy, forces every site to now use another module even if they don't 'need svg' at this time.
Certainly, would be nice if Drupal Core had an SVG solution in place to work with. - miiimooo Europe
Adding a re-roll of the patch in #13 for 2.1.0
The patch in #27 adds some check which is not part of this patch