🇨🇦Canada @SKAUGHT

duplicate of #3420902

certainly, lots of open tickets around this in core..

Drupal issues search | "text=not+compatible&component=update.module" →

this is how this module is currently set for release status:

it seems like core isn't figuring out that what's recommended isn't geared per core release.

As per #50 and #48. I'll move to RTBC logo is aligned with the rest of items below, matching overall design mocks.

#48 notes. " But there should be some space between logo and slider." I would agree the width of the entire item might ought to be wider but that scope that might pushing this ticket IMO. Also, as we know various browsers use different widths.

to be clear, I was staffed by Optasy for work on the estore project.

thanks for confirming your hosting platform. Indeed, this module IS NOT STABLE!!

this module is not maintained!

umm.. I see you have scrollbars being displayed. Do you have your setup to always show them?

preview with flex-shrink attached, shows both of our toggles between breakpoints.

local demo image was just 71*83 pixel grab (then autosized as expected to 34x40).

skaught → changed the visibility of the branch 3462829-store-the-file to hidden.

skaught → made their first commit to this issue’s fork.

have reviewed patch. yes oversight in original name spacing for file usage.

will also probably need an update hook to check if any update any existing entries to be updated to 'file' (as $new_logo_managed->getEntityTypeId() will equal 'file').

also was using drupal 11 (a new site, not an updated project). I had come across several other bug/error notices. this is the only one that was fatal/wsod.

skaught → created an issue.

skaught → created an issue.

the_g_bomb → credited skaught → .

skaught → created an issue.

on 3.x dev I am now converting to a custom field. time to rebuild this tool.

opening as 2.1.x dev line. I do still want to rebuild this (to SDC, general modernize). but time, as always....

overall, 'allowing empty' this is not a operation I want this model to have.

second note, patch does not have need tests.

pameeela → credited SKAUGHT → .

would you be able to outline the advantage of this hook? simply, what is your use-case that you need to alter the like that you can not 'use custom title' not be useful??

also: needs tests.

[#3344141]. ScrollTopCommand is now a core command.

have added composer file and adjusted module info for 10.1. -> 11. have tested on d11 locally

SKAUGHT → made their first commit to this issue’s fork.

see: https://www.drupal.org/project/auctions/issues/3460496#comment-15718255 🐛 Use IEF ^1.0 || ^3.0 Closed: works as designed

@d11 and forward
https://www.drupal.org/project/auctions/releases/3.0.x-dev →
this is resolved on the 3.x line, in that we will use v3 future forward. thanks!

hestenet → credited SKAUGHT → .

SKAUGHT → created an issue.

most generally, We should account for more space then just 2 active languages. As often sites can have 4-7. this would make the desktop design (to show as inline items) not as 'ready out of the box' considering the 'head width' available.

-Put a button in that block with the hidden attribute on it, so it's not visible on the page
-Use JS to remove that hidden attribute so we can see the button
-Use JS to add a hidden attribute to the languages so they are now invisible

A. are you concerned with JS degrade, or just the breakpoint hide/showing.
B. a reminder of projects like https://www.drupal.org/project/dropdown_language → (which i maintain) to remind that Unami Profile can provide a block plugin that is the block to be placed with whatever Accessible Ready UI (button and links) with the true language paths and SEO readhy hreflang's.

#28. "YML plugin declaration of icons sets to be added to modules and icons..."

nice. "a standardized way across Drupal"

@ahsannazir thanks for the followup. hiding old branch to reduce confusion.

SKAUGHT → changed the visibility of the branch 3444391-center-small-navigation to hidden.

re-started from up to date clean branch

re: Say there is a design change to increase the image size to 45*45 pixels,
✨ Center small navigation logo on collapsed state Needs review would be the fallback to address images that are too small.

@siliconmeadow
Can you set the default branch to 2.1.0 now. I do not have perm in gitlab.

Am releasing 2.1.x line for Drupal 11 (PHP 8.3+) only. will also allow Stats page to be more useful ( emptyparagraphkiller Usage Stats → )

#18 Crop module 8.x-2.4 has now been released!!!!

no, it required by, nor first. it would be a different set of tests at well.

💬 Update module erroneously recommends conflicting update to 6.1.x for sites on Drupal 10.0.x or lower Closed: works as designed is using an update hook of Update Module to 'short-cut' this.

if the problem is still (untill d11 is actually out, and if core themselves need to update Update module around this in a wider way across conbrib -- i will continue to wait to see that result.

again, i blame update manager: this is confusing that the 4.1 line is indeed not with 10.3 (as it was in 10.2). i can not guess at the 'Requires Drupal core:" is blank off hand. again, this is internal to update manager.

low concern.

core_version_requirement is correctly set by {dropdown language} for both these releases, and follows my long-term tagging strategy. as does my composer setup to keep major core version apart with my release cycles.

-> I have no control over Update Manager messaging. this bug seems like theres, not mine.

otherwise, Dropdown Language is operating normally correct? (:

I would have to assume you have been using v4.0.3 through your entire Drupal 10 life cycle?

patch 404 applies as expected on Drupal 11.0.x.

There is something wrong with gitlab. I can not start a new branch or pull in current dev head to get this patch into. This is probably why 404 is a file.

benjifisher → credited SKAUGHT → .

logo is not aligned with rest of first items.

benjifisher → credited SKAUGHT → .

If you are looking to begin this work, of course -- please feel fee to. I'll be happy to consider at the time a patch exists.

linking

This is looking good across our general needs and has tests!

• An oversized 16:9 image shows user notice of action.
  
• undersized is left alone and the dimensions are correct for eager loading.
  

Also now 🐛 Custom Navigation logo is disconnected from new Layout template Fixed is in. Branch needs to be updated.

SKAUGHT → created an issue.

I'll returning to RTBC again, thanks!

benjifisher → credited SKAUGHT → .

am finding in TocFilterBlock ln 34 $format_id is null, we need to verify this.

i'll return to RTBC. thanks!

we need to make sure the image is v/h centered in a 40px A tag that wraps the custom image used. remember 📌 Adjust custom navigation logo dimensions on upload Fixed is also coming soon, images will be scaled down.

Bartik (old core) and Gin as contrib are good reminders that this issue is against the media module and should be more toward stark as base module, or media component itself.

SKAUGHT → changed the visibility of the branch 3436526-create-image-styles to hidden.

benjifisher → credited SKAUGHT → .

yes, a correctly defined width and height attributes with fallback to svg viewBox if defined. i had mocks on that on other branches but we didn't have a sanitize routine worked out there.

just a reminder also we do need the correct size for the img as the logo is eager loading. we do output the correct image size from existing routing with a custom image.

(: lol. so much work for such a small picture

u mean something like:

use Drupal\Core\Image\ImageFactory;
...
$image_factory = \Drupal::service('image.factory');
$image = $image_factory->get($file->getFileUri());

if ($image->isValid()) {
   // Scale the image to fit within 40x40 pixels, maintaining aspect ratio.
   if ($image->scale(40, 40)) {
      // Save the scaled image.
      $image->save();
 ....

plopesc
the precursor problem is Image (core module) is enable and Servers have php's GD Library Enabled. As i've thought around this: we should just enforce a 40x40image and not offer to resize. And 'IF' down the line we allow svg --> same only verify size, let the user use the correct file in the first place.

test are running green again.

#32, indeed there are some open conversations around this.

📌 [meta] Improve the navigation layout page Active maybe the best issue to point you to.

Tests for each of the 3 general logo handling options. A bit of a shortcut to setup for op3 to preset the config itself and verify the current fid will be ready for #3436526 and it's tests.

@Gauravvvv: what browser are you using?

I have seen results/glitch like this i think more around cache clearing and working with various branch work. this may need some further debugging if it continues.

Proposed resolution: The current resolution is to add BOTH types? This is not a clear direction.
As the actions are JS events/triggers only, button is correct as we do not have a full form submit.

benjifisher → credited SKAUGHT → .

#17
cache clearing is not resolution. it's just a 'stop gap' to get back up.

the problem is not just with an Acquia Deployment that this happens, i know this from my own direct experience in Acquia.

Certainly!
It is true, unless I add an item the main branch item doesn't appear.

🐛 Navigation glitch with Shortcuts and Minimal Profile Active have opened for followup.