Certainly!
It is true, unless I add an item the main branch item doesn't appear.
🐛 Navigation glitch with Shortcuts and Minimal Profile Active have opened for followup.
After installing Minimal profile, then going to admin/extend to enable Navigation (alone) it is initializing without error. As we did not enable Shortcuts the item is not there (so far as expected!).
-next, enable shortcuts module. notice: no "(star) shortcuts" appears at top of all others.
- clear cache. does not "(star) shortcuts" item to appear.
-next step to try: disable navigation. LEAVE Shortcuts ENABLED!.
- clear caches.
- re-enable navigation. still no "(star) Shortcuts" item.
---
meanwhile: reinitialize env -- install regular standard profile, then enable navigation -- "(star) shortcuts" is working as expected.
@ahsannazir thanks!
I have also retested this morning and can not recreate what I had seen. I think I had a local cache problem from branch changes. I'll move to RTBC.
benjifisher → credited SKAUGHT → .
CRITICAL --> (mid may/2023) Crop API itself is not D11 ready how is this being tested!!!!
Steps forward!
I'm still finding some general switching it from narrow and back and forth again the overhand is reoccurring.
SKAUGHT → changed the visibility of the branch 3443810-custom-nav-logo-disconnect-fix to hidden.
there seems to be test fails everywhere for this project at this time.
ie:
📌
Automated Drupal 11 compatibility fixes for amp
Needs review
The lower 'narrow/expand' button is now locked open if user click. the left side of the page content remains fixed left (remains partially hidden under the entire nav.
Drupal Usability Meeting 📌 Drupal Usability Meeting 2024-05-10 Active reviewed 🐛 Regression: not possible to delete source strings in Drupal (>7) interface translation Needs review
[placeholder for notes]
SKAUGHT → created an issue. See original summary → .
Thanks, i see that aspect too.
🐛 In a Drupal site with low resource use (minimal profile) Navigations 'Create section' is missing key items. Active had just noticed some other similar dependency calls working a bit strangely still.
SKAUGHT → created an issue.
We're missing a breadcrumb more that a return link which then fills the space we need (sm->mid breakpoint ranges)
noting:
- right most icon is meant to be Node Forms vertical tabs
- actions include old style tab items (ie: revision, also normal for developers 'devel' would follow)
Navigation should have a 'pill' plugin item that lets contrib/core components simply add this 'link' for this wider 'task markers'
thanks @catch
A good thought around keeping a 'softer dependency' this way.
Navigation overall supports more menu that are active in the overall project than just Administration as our first focus. Many other menu's do often have 4-6 layers too.
Yes, as Navigation should be able to handle any menu that has greater depth!
Redirecting the depth of what is in 'all the modules' that add into this one menu and their organizing is the extending goal. This would then need followup against every other (core component) that is providing the link/links.
As I understand that Gin does have a tool 'navigation' already. Should this not be against Gin, Gin toolbar as it is now true that 'navigation' is a core namespace, and it is contrib will have to alter around this now?
workaround CAN be found by user. reducing priority to match related.
I'm sure this is due to drupal.displace and inner JS action.
this is not due to profile, nor theme.
have tested branch. attached mov of profile and enabling of Navigation.
works as expected!
As I have some other work todo and there is much happening next week, i'll take move to needs work so that it may be picked up meanwhile.
I have just added some outlining notes to this WIP in the test page for insights. It does not actually test yet (:
benjifisher → credited SKAUGHT → .
Have been in communication around 🐛 Navigation Test names are disjointed. Active and 🐛 Enhance Navigation admin workflow with Managed Tabs. Needs review . It is clear that we have the scope to start a new test for this, this way.
Ready with tests for managed tabs flow!
thanks @plopesc
I myself am understanding more about what's happening with these tests, as we all are.
maybe both these are related to offset use.
🐛 Enhance Navigation admin workflow with Managed Tabs. Needs review will be adding a 'NavigationBaseTest' item when accepted.
Technically it works. LOL. I agree, lets focus on the bright side!
reminder 'too small'
In general, yes of course! As this break was so late before the MR and has the standing ticket for related tests, this as a direct repair could be seen to given the work now on dev line.
In general, the tests did shift too with moving to layout builder, I don't have a clear base for where to setup some of the testing. #344355: SbT doesn't respect node access? → .
Problem/Motivation
Recent change to Layout Builder has left Custom Logo Option without it's path and image size.
Steps to reproduce
Goto Drupal 11 dev line and enable Navigaiton module. goto 'Nafivation settings' config page and setup with a file.
Proposed resolution
Reconnect variable to twig.
Remaining tasks
📌 Add tests for the new feature to change the logo Active .
User interface changes
N/A.
API changes
N/A.
Data model changes
None.
Release notes snippet
yes, of course we should begin. Am just linking this new aspect of logo use.
🐛
(navigation layout) logo settings are disconnected.
Active
. I'll see about this fix and should be able to start some related tests for file and display as base.
SKAUGHT → changed the visibility of the branch 3441586-navigation-logo-does to active.
SKAUGHT → changed the visibility of the branch 3441586-navigation-logo-does to hidden.
SKAUGHT → changed the visibility of the branch 3441586-navigation-logo-does to hidden.
I realize this issue is currently more geared around the basic design guide of the overall project.
@finnsky - what you are showing with adding into announcements_feed.links.menu.yml* is a great insight into how others can use this.
*needs developer/conrib demo doc.
Maybe another ticket is needed:
#10 -- I've continued some local POC to be able to 'select a file' from the block config. This would open in Settings Tray while editing menu levels and use the current 1st to add an 'naviagation_icon_fid' as as menu 'optional data' through the context link of the layout navigation builder.
Similarly if using an icon library, then this could let users select from a UI .
- add a settings for the library prefix? if site has other libraries
- also render . would allow more to be done by theming/contrib.
maybe an addition question is users add a file or selects an icon from UI is
- how can user user other icon libraries? this is singular to one design library (long term?) and run puts
- imagecache use consideration (same as logo).
Navigation has been accepted to Drupal 11 dev line now. I'll close this as is no longer valid. thanks!
We have come across a more specific problem on the new layout form (see details there) in a completely different light, and as the solution unfolded we then realized -- same solution! dups happen (:
cheers. I've added comment to add you for cred there as well.