Account created on 20 May 2008, about 16 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada SKAUGHT

@siliconmeadow
Can you set the default branch to 2.1.0 now. I do not have perm in gitlab.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Am releasing 2.1.x line for Drupal 11 (PHP 8.3+) only. will also allow Stats page to be more useful ( emptyparagraphkiller Usage Stats β†’ )

πŸ‡¨πŸ‡¦Canada SKAUGHT

#18 Crop module 8.x-2.4 has now been released!!!!

πŸ‡¨πŸ‡¦Canada SKAUGHT

no, it required by, nor first. it would be a different set of tests at well.

πŸ‡¨πŸ‡¦Canada SKAUGHT

πŸ’¬ Update module erroneously recommends conflicting update to 6.1.x for sites on Drupal 10.0.x or lower Closed: works as designed is using an update hook of Update Module to 'short-cut' this.

if the problem is still (untill d11 is actually out, and if core themselves need to update Update module around this in a wider way across conbrib -- i will continue to wait to see that result.

"{my D}rupal installation in an outdated state." outdated -- i assuming your site is running fine otherwise and this is only an notice to a dev/admin and can be explained at this time.
πŸ‡¨πŸ‡¦Canada SKAUGHT

again, i blame update manager: this is confusing that the 4.1 line is indeed not with 10.3 (as it was in 10.2). i can not guess at the 'Requires Drupal core:" is blank off hand. again, this is internal to update manager.

low concern.

πŸ‡¨πŸ‡¦Canada SKAUGHT

core_version_requirement is correctly set by {dropdown language} for both these releases, and follows my long-term tagging strategy. as does my composer setup to keep major core version apart with my release cycles.

-> I have no control over Update Manager messaging. this bug seems like theres, not mine.

otherwise, Dropdown Language is operating normally correct? (:

πŸ‡¨πŸ‡¦Canada SKAUGHT

I would have to assume you have been using v4.0.3 through your entire Drupal 10 life cycle?

πŸ‡¨πŸ‡¦Canada SKAUGHT

patch 404 applies as expected on Drupal 11.0.x.

There is something wrong with gitlab. I can not start a new branch or pull in current dev head to get this patch into. This is probably why 404 is a file.

πŸ‡¨πŸ‡¦Canada SKAUGHT

logo is not aligned with rest of first items.

πŸ‡¨πŸ‡¦Canada SKAUGHT

If you are looking to begin this work, of course -- please feel fee to. I'll be happy to consider at the time a patch exists.

πŸ‡¨πŸ‡¦Canada SKAUGHT

This is looking good across our general needs and has tests!

  • An oversized 16:9 image shows user notice of action.
  • undersized is left alone and the dimensions are correct for eager loading.
πŸ‡¨πŸ‡¦Canada SKAUGHT

am finding in TocFilterBlock ln 34 $format_id is null, we need to verify this.

πŸ‡¨πŸ‡¦Canada SKAUGHT

we need to make sure the image is v/h centered in a 40px A tag that wraps the custom image used. remember πŸ“Œ Create Image Styles for Nav Logo Active is also coming soon, images will be scaled down.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Bartik (old core) and Gin as contrib are good reminders that this issue is against the media module and should be more toward stark as base module, or media component itself.

πŸ‡¨πŸ‡¦Canada SKAUGHT

SKAUGHT β†’ changed the visibility of the branch 3436526-create-image-styles to hidden.

πŸ‡¨πŸ‡¦Canada SKAUGHT

yes, a correctly defined width and height attributes with fallback to svg viewBox if defined. i had mocks on that on other branches but we didn't have a sanitize routine worked out there.

just a reminder also we do need the correct size for the img as the logo is eager loading. we do output the correct image size from existing routing with a custom image.

(: lol. so much work for such a small picture

πŸ‡¨πŸ‡¦Canada SKAUGHT

u mean something like:

use Drupal\Core\Image\ImageFactory;
...
$image_factory = \Drupal::service('image.factory');
$image = $image_factory->get($file->getFileUri());

if ($image->isValid()) {
   // Scale the image to fit within 40x40 pixels, maintaining aspect ratio.
   if ($image->scale(40, 40)) {
      // Save the scaled image.
      $image->save();
 ....
πŸ‡¨πŸ‡¦Canada SKAUGHT

plopesc
the precursor problem is Image (core module) is enable and Servers have php's GD Library Enabled. As i've thought around this: we should just enforce a 40x40image and not offer to resize. And 'IF' down the line we allow svg --> same only verify size, let the user use the correct file in the first place.

πŸ‡¨πŸ‡¦Canada SKAUGHT

#32, indeed there are some open conversations around this.

πŸ“Œ [meta] Improve the navigation layout page Active maybe the best issue to point you to.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Tests for each of the 3 general logo handling options. A bit of a shortcut to setup for op3 to preset the config itself and verify the current fid will be ready for #3436526 and it's tests.

πŸ‡¨πŸ‡¦Canada SKAUGHT

@Gauravvvv: what browser are you using?

I have seen results/glitch like this i think more around cache clearing and working with various branch work. this may need some further debugging if it continues.

Proposed resolution: The current resolution is to add BOTH types? This is not a clear direction.
As the actions are JS events/triggers only, button is correct as we do not have a full form submit.

πŸ‡¨πŸ‡¦Canada SKAUGHT

#17
cache clearing is not resolution. it's just a 'stop gap' to get back up.

the problem is not just with an Acquia Deployment that this happens, i know this from my own direct experience in Acquia.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Certainly!
It is true, unless I add an item the main branch item doesn't appear.

πŸ› Navigation glitch with Shortcuts and Minimal Profile Active have opened for followup.

πŸ‡¨πŸ‡¦Canada SKAUGHT

After installing Minimal profile, then going to admin/extend to enable Navigation (alone) it is initializing without error. As we did not enable Shortcuts the item is not there (so far as expected!).
-next, enable shortcuts module. notice: no "(star) shortcuts" appears at top of all others.
- clear cache. does not "(star) shortcuts" item to appear.
-next step to try: disable navigation. LEAVE Shortcuts ENABLED!.
- clear caches.
- re-enable navigation. still no "(star) Shortcuts" item.
---
meanwhile: reinitialize env -- install regular standard profile, then enable navigation -- "(star) shortcuts" is working as expected.

πŸ‡¨πŸ‡¦Canada SKAUGHT

@ahsannazir thanks!
I have also retested this morning and can not recreate what I had seen. I think I had a local cache problem from branch changes. I'll move to RTBC.

πŸ‡¨πŸ‡¦Canada SKAUGHT

CRITICAL --> (mid may/2023) Crop API itself is not D11 ready how is this being tested!!!!

πŸ‡¨πŸ‡¦Canada SKAUGHT

Steps forward!
I'm still finding some general switching it from narrow and back and forth again the overhand is reoccurring.

πŸ‡¨πŸ‡¦Canada SKAUGHT

SKAUGHT β†’ changed the visibility of the branch 3443810-custom-nav-logo-disconnect-fix to hidden.

πŸ‡¨πŸ‡¦Canada SKAUGHT

there seems to be test fails everywhere for this project at this time.
ie: πŸ“Œ Automated Drupal 11 compatibility fixes for amp Needs review

πŸ‡¨πŸ‡¦Canada SKAUGHT

The lower 'narrow/expand' button is now locked open if user click. the left side of the page content remains fixed left (remains partially hidden under the entire nav.

πŸ‡¨πŸ‡¦Canada SKAUGHT

SKAUGHT β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada SKAUGHT

We're missing a breadcrumb more that a return link which then fills the space we need (sm->mid breakpoint ranges)

noting:
- right most icon is meant to be Node Forms vertical tabs
- actions include old style tab items (ie: revision, also normal for developers 'devel' would follow)

πŸ‡¨πŸ‡¦Canada SKAUGHT

Navigation should have a 'pill' plugin item that lets contrib/core components simply add this 'link' for this wider 'task markers'

πŸ‡¨πŸ‡¦Canada SKAUGHT

thanks @catch
A good thought around keeping a 'softer dependency' this way.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Navigation overall supports more menu that are active in the overall project than just Administration as our first focus. Many other menu's do often have 4-6 layers too.
Yes, as Navigation should be able to handle any menu that has greater depth!

Redirecting the depth of what is in 'all the modules' that add into this one menu and their organizing is the extending goal. This would then need followup against every other (core component) that is providing the link/links.

πŸ‡¨πŸ‡¦Canada SKAUGHT

As I understand that Gin does have a tool 'navigation' already. Should this not be against Gin, Gin toolbar as it is now true that 'navigation' is a core namespace, and it is contrib will have to alter around this now?

πŸ‡¨πŸ‡¦Canada SKAUGHT

workaround CAN be found by user. reducing priority to match related.

πŸ‡¨πŸ‡¦Canada SKAUGHT

I'm sure this is due to drupal.displace and inner JS action.
this is not due to profile, nor theme.

πŸ‡¨πŸ‡¦Canada SKAUGHT

have tested branch. attached mov of profile and enabling of Navigation.
works as expected!

πŸ‡¨πŸ‡¦Canada SKAUGHT

As I have some other work todo and there is much happening next week, i'll take move to needs work so that it may be picked up meanwhile.

I have just added some outlining notes to this WIP in the test page for insights. It does not actually test yet (:

πŸ‡¨πŸ‡¦Canada SKAUGHT

Have been in communication around πŸ› Navigation Test names are disjointed. Active and πŸ› Enhance Navigation admin workflow with Managed Tabs. Needs review . It is clear that we have the scope to start a new test for this, this way.

πŸ‡¨πŸ‡¦Canada SKAUGHT

Ready with tests for managed tabs flow!

πŸ‡¨πŸ‡¦Canada SKAUGHT

thanks @plopesc
I myself am understanding more about what's happening with these tests, as we all are.

Production build 0.69.0 2024