Allow hiding configured blocks in layout builder

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re-rolled #15

error: patch failed: core/modules/layout_builder/css/layout-builder.css:96
error: core/modules/layout_builder/css/layout-builder.css: patch does not apply

Added tests, please review

Going to go ahead and mention seems this is pulling from existing tests, could we not just extend on one of those vs doing a whole new instance

Minimum it probably could be included in LayoutBuilderUiTest

Included the test in LayoutBuilderUiTest but created a new function, because the existing functions look like they are testing a particular functionality.

please review

Will remove the tests tag for now.

Think to get a proper answer for #15 it will need usability review.

Also will require a change record.

Re-rolling patch for Drupal 10.3.0

Hi,
Can I use this patch on Drupal 10.3.1? https://www.drupal.org/files/issues/2024-06-28/3163197-32.patch →

Thanks for building it! Greetings,

This doesn't work for drupal 10.2.7

Changes are made on the main development branch, 11.x, and then backported according to our policies. Also, 10.2 is only receiving security updates now.

I looked into the difficulty of having different title text for the contextual link depending on if it was being shown or hidden. Having dynamic text can be done by extending ContextualLinkDefault and overriding the getTitle() method, however any kind of dynamic title will be complicated by the fact that contextual links are cached in local storage.

Here's a re-roll of the patch against 11.x

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Updated the merge request

Did not review but pipeline appears to have issues.

joelpittet → changed the visibility of the branch 3163197-allow-hiding-configured to hidden.

Hi, is there any patch available for 10.3.11 the patch in Comment#33 ✨ Allow hiding configured blocks in layout builder Needs work doesn’t work for the Drupal version 10.3.11.

Any new patch for Drupal 10.3.11?

Is there a new patch available for Drupal 10.3.11?

Here's a patch that's the current state of the merge request and it applies on 10.4.3.

I looked into the difficulty of having different title text for the contextual link depending on if it was being shown or hidden. Having dynamic text can be done by extending ContextualLinkDefault and overriding the getTitle() method, however any kind of dynamic title will be complicated by the fact that contextual links are cached in local storage.

The current MR's tests are passing. If having different text for the contextual links is the only hold up, could we consider an alternative label that doesn't change?

Marking as needs review in hopes of getting this merged -

Just reviewed the first file and the return types for the translation trait are definitely out of scope of this issue.

If the baseline file needs to be updated for using it that’s fine

Also summary appears to be slight deviation from the standard template but the user interface section that’s part of the standard template should have a before after screenshots for the usability team

Saving credit for jastratt for the work

Using the get() and set() methods on SectionComponent will result in the setting being stored in the additional property because a hidden property doesn't exist. ✨ Support third party settings for components within a section Needs work seeks to replace the additional property with third-party settings. I'd recommend adding a hidden property to the SectionComponent class to avoid creating technical debt.