The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India ranjith_kumar_k_u Kerala
Re-rolled #15
error: patch failed: core/modules/layout_builder/css/layout-builder.css:96
error: core/modules/layout_builder/css/layout-builder.css: patch does not apply - Status changed to Needs review
over 1 year ago 2:58pm 23 March 2023 - Status changed to Needs work
over 1 year ago 10:25pm 23 March 2023 - 🇺🇸United States smustgrave
Going to go ahead and mention seems this is pulling from existing tests, could we not just extend on one of those vs doing a whole new instance
- 🇺🇸United States smustgrave
Minimum it probably could be included in LayoutBuilderUiTest
- 🇮🇳India ranjith_kumar_k_u Kerala
Included the test in LayoutBuilderUiTest but created a new function, because the existing functions look like they are testing a particular functionality.
please review
- 🇺🇸United States smustgrave
Will remove the tests tag for now.
Think to get a proper answer for #15 it will need usability review.
Also will require a change record.