Center small navigation logo on collapsed state

@finnsky Can confirm the issue only happens when the inspect element is open and the toolbar gets a scrollbar on it

I am attaching a screen record as a reference and looking into this issue.

Thank you for your work. I've added comment with suggestions.

@finnsky Thanks for MR feedback. I have used width instead of max-width with the intention to make it look similar to the default logo dimensions. If using max-width, the small image logos will be little left aligned so thought of giving the width of 40px(same as default logo).

MR appears to have failures now.

FYI @immaculatexavier and @sakthi_dev this issue was tagged for novice for new users. Looking at your posts you have several 100 posts so probably can avoid novice level issues.

Getting error while applying patch

@divya.sejekan

Could you please add more informative feedback? Which patch, which error? Thank you

We're working on this in the DrupalCon 2024 mentoring contrib room. We will:

• Test the patch.
• Update the status if needed.

Hi
I've tried to apply MR !7897 on drupal 11.x
but Getting error while appling MR

Adding Error SS for reference

For good practice lets complete the issue summary.

Got it started.

we need to make sure the image is v/h centered in a 40px A tag that wraps the custom image used. remember 📌 Adjust custom navigation logo dimensions on upload Fixed is also coming soon, images will be scaled down.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Also now 🐛 Custom Navigation logo is disconnected from new Layout template Fixed is in. Branch needs to be updated.

Hi, I’ve tested MR 7897 on Drupal 11.x.
The MR applied cleanly.

Testing steps:
1. Enable the Navigation module.
2. Goto the module’s settings page.
3. Choose a custom logo from the logo options.
4. Upload a small logo.
5. Check the horizontal alignment of the logo in the collapsed toolbar state.

Test Result:
The logo position has been centered after the MR changes.

Attaching screenshots for reference.

Thanks!

logo is not aligned with rest of first items.

This only happens when the vertical scroll bar appears. The rest of icons are not center aligned when the scroll appears. Not sure what should be done to solve this case.

I've added one small comment. Could you please take a look?

re-started from up to date clean branch

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

SKAUGHT → changed the visibility of the branch 3444391-center-small-navigation to hidden.

@ahsannazir thanks for the followup. hiding old branch to reduce confusion.

1. I think small logo should not move on collapse/expand

https://gyazo.com/084fb9ee2af2b6399caa70f122536303

2. one comment in MR about RTL

3. I don't think test.png image should be in repo.

I have reviewed this patch.
I have applied MR !8893 on drupal 11.x, applies without any issue.

Steps to Reproduce:
1. Enable the Navigation module.
2. Goto the module’s settings page.
3. Choose a custom logo from the logo options.
4. Upload a small logo.
5. Check the horizontal alignment of the logo in the collapsed toolbar state.

The logo position has been centred after the MR changes.

Attaching screenshots for reference.

Status of this issue can me moved ahead

RTBC +

I think the status change was missing

Not sure how I feel about all this CSS for just that, but with one more css line it works.

preview with flex-shrink attached, shows both of our toggles between breakpoints.

local demo image was just 71*83 pixel grab (then autosized as expected to 34x40).

Hi, I’ve tested MR 8893 on Drupal 11.x.
The MR applied cleanly.

Testing steps:
1. Enable the Navigation module.
2. Goto the module’s settings page.
3. Choose a custom logo from the logo options.
4. Upload a small logo.
5. Check the horizontal alignment of the logo in the collapsed toolbar state.

Test Result:
The logo position has been cantered after the MR changes. But there should be some space between logo and slider.

Attaching screenshots for reference.

umm.. I see you have scrollbars being displayed. Do you have your setup to always show them?

Verified the changes in MR!8893 in Drupal version 11.x and can confirm that it fixes the issue. The position remained centre aligned even while scrolling the navigation bar (please refer the screen recording). Attaching before and after screenshots as well. Need RTBC+1

Before:

After:

Updated IS with latest screenshots.

As per #50 and #48. I'll move to RTBC logo is aligned with the rest of items below, matching overall design mocks.

#48 notes. " But there should be some space between logo and slider." I would agree the width of the entire item might ought to be wider but that scope that might pushing this ticket IMO. Also, as we know various browsers use different widths.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I reviewed the changes and noticed that the issue is resolved in the Drupal version. The position stayed centered; then I moved the navigation bar, and it maintained its position without any issues.

There is a merge issue to resolve