๐Ÿ‡ฎ๐Ÿ‡ณIndia @ehsann_95

Account created on 19 April 2016, about 8 years ago
  • Frontend Engineer at QED42ย  โ€ฆ
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The image style is getting applied after following the Help topic. The Help topic is to the point.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Yes @atowl both works. I'd prefer the original way like it was before. Replacing the values on the class itself

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Yes there are also other places where styles are getting overriden by umami. I agree with #2 and #3, we need to increase the specificity for selectors.
e.g: .toolbar-menu__link:hover to a.toolbar-menu__link:hover

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

@atowl Can't we replace the padding value on the same class instead of shifting the padding values to the span?

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Reproduced the issue with the given steps and was able to see the issue. The issue seems fixed after applying the MR. Moving to RTBC

Before:

After:

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The Keyboard navigation is working as expected. Attaching the screen capture for the reference

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Thanks @bronzehedwick. I think now the toolbar popover is behaving as it should and the provided solution looks good to me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

IMO it should toggle either on hover or on click. If the popover is opened on hover then why we need click to toggle show/hide the same popover. Can someone look into this and confirm that the current behavior implemented is what we want

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

I can't reproduce it either. Its working as expected. Can we close this issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The keyboard navigation is now working fine. I just fixed some linting prettier errors. Attaching screen recording for reference

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Removed the vertical padding as suggested because there is already ample spacing coming from grid-gap.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The cs spell is failing due to cross.svg saying Forbidden word (grey)

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Removed !important and added a style to target the class specifically.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

In the above raised MR, the Funtional Javascript test cases are failing and there are console errors as well

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ changed the visibility of the branch 3238868-refactor-parents to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ changed the visibility of the branch 3239531-refactor-closest to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Can someone look into the MR and confirm why Tests Pipelines are failing. Seems like few test cases are failing but not sure why

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Yes got it. I have used closest() with the intention that it works without jquery.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

I was not able to reproduce the issue with given steps. Moving issue to NR

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

I also tried to reproduce the issue with given steps. I was not able to find any spacing or alignment issues and everything looked good to me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Raised MR for hiding dropdown when clicking outside dropdown

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Raised MR to add box-shadow for dropdown

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

MR for fixing the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The issue is occurring when we have Legacy toolbar selected in Gin settings. Raised a MR to fix the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Can you please add more details to reproduce the issue. Its working fine for me

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Raised a MR to fix the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Created MR to fix the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Can you add more details or a video to understand the issue. I tried reproducing the issue but Edit button was visible on large screens as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The hover effect was coming from claro css.

.tabs__link:hover {
color: var(--color-text);
}

So updated MR to override tabs__link directly

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

I tried the steps mentioned in #21 and was not able to reproduce the issue. This needs more research/info when this happens.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

Pipelines are passing now. so moving to NR

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

The one of the piplelines is broken. I tried raising another MR but no luck

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

ahsannazir โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

This issue ๐Ÿ“Œ Olivero: Rename "wide-image" CSS class to "wide-content" Fixed can help us to understand why this was added

๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

I agree with #21 to close this issue. Since this css file no longer exists in Core.

Production build https://api.contrib.social 0.62.1