nod_ → credited ahsannazir → .
ahsannazir → made their first commit to this issue’s fork.
I am not able to reproduce the issue. Attaching screenshots for reference
@finnsky, This makes sense and the above/inline field display is working as expected.
Inline:
Above:
The styles are looking as expected. Only thing i can figure out is the flex direction is column now. Attaching screenshot below
@sanket.tale The double status messages get printed on the page when you have try to add/remove blocks
ahsannazir → changed the visibility of the branch 11.x to hidden.
The SVG code has been removed from twig file and SVG has been moved to images/src folder.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
The close btn is keyboard accessible now and also verified pressing the Esc key closes the menu.
@riddhi.addweb Can you please follow the Steps to reproduce once again. i am able to see slogan . attaching screenshot
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
@finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?
The Meta component is looking as expected.
Created MR from patch given in #6
ahsannazir → made their first commit to this issue’s fork.
@SystemLord Can you please add Screenshot or screen recording to help identify the issue
The labels are getting fixed in
https://www.drupal.org/project/drupal/issues/3446433
🐛
Navigation: Theme aside layout builder section on navigation block page
Needs work
. Lets wait for it to be fixed first.
Attaching screenshot what it should like after above issue gets fixed
The layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|
i could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
Attaching screenshot how it looks with font-size of 1rem.
Created MR from #71
ahsannazir → made their first commit to this issue’s fork.
The hover styles on submenu child items are not as per the design shared above. Attaching sccreencapture
The font size is smaller now. Attaching screenshot for ref
This only happens when the vertical scroll bar appears. The rest of icons are not center aligned when the scroll appears. Not sure what should be done to solve this case.
The SDC component for meta is working as expected. Attaching screenshot for reference.
ahsannazir → made their first commit to this issue’s fork.
Resetting/overriding the width works because the width set in layout.css for body.is-fixed .container is incorrect for this case.
Changing vertical-align to top also changes alignment for small section fields. Check screenshot below
ahsannazir → made their first commit to this issue’s fork.
It seems reseting width fixes the issue. Attaching screenshot for reference.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → created an issue.
ahsannazir → made their first commit to this issue’s fork.
The shadow is shown both on Desktop & Mobile when data-detected-y-overflow="true"
The 2nd point mentioned in #32 about flickering needs to be investigated more and fixed accordingly.
Yes now i can see the tooltip. It also happens when you enable "Display title " checkbox for the existing blocks in navigation toolbar
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → changed the visibility of the branch 3438878-regression-the-drawer to hidden.
Not able to reproduce the issue . Attaching screen capture for reference.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
The pipeline is still failing for the MR. Not sure why it is failing.
Drupal\Tests\file\Functional\DownloadTest::testPrivateFileTransferWithoutPageCache
Correctly denied access to a file when file_test sets the header to -1.
Failed asserting that 200 is identical to 403.
/builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:138
/builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:76ahsannazir → made their first commit to this issue’s fork.
The code changes seems fine and the spinner is rendering below gear icon. Attaching screen capture for reference.
The issue was happening due to transform property in the svg itself. Fixed the SVG and moved style to stylesheet
I restested to see the issue mentioned in #18 but was not able to reproduce the same. Attaching screen capture for reference
The changes look fine and are working as expected on safari as well.
Made changes to the MR. Attached screen capture for ref.
Thanks @bnjmnm for the suggestions. I have added the the no-script css and attached screen capture for reference
The changes are working fine. Attaching screen capture
Not able to reproduce the issue. I have added screenshots for reference.
Can you please add more details
ahsannazir → made their first commit to this issue’s fork.
Moving this to NR to confirm if it is working as expected
The MR in #29 looks good. All tablinks are bottom aligned now. Attaching screenshots for ref.
I also see the border-bottom of focus outline is not visible. Do we need to keep it as it is or it also needs a fix?
The issue is not reproducible at my end. I see the css already present to handle this scenario.
.site-branding--bg-gray .site-branding__text,
.site-branding--bg-white .site-branding__text {
color: var(--color--primary-50);
}
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.