ahsannazir → made their first commit to this issue’s fork.
The class is getting added as per #24 But the session storage still sets activeTabId to toolbar-item-shorcuts
{
"orientation": "horizontal",
"hasActiveTab": true,
"activeTabId": "toolbar-item-shortcuts",
"activeTray": "toolbar-item-shortcuts-tray",
"isOriented": true,
"isFixed": true,
"userButtonMinWidth": 0
}ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
Created a MR as per #42
ahsannazir → made their first commit to this issue’s fork.
@christosgeorgiadis I have made some changes to the css, can you please check it again
Please make style changes to the scss files only and use build command to generate corresponding css. The build is failing due to the recent commits
ahsannazir → made their first commit to this issue’s fork.
Removing justify-content: center fixes the alignment of Status items.
ahsannazir → changed the visibility of the branch 3471459-prefixsuffix-not-inline to active.
ahsannazir → changed the visibility of the branch 3471459-prefixsuffix-not-inline to hidden.
The pipeline is failing due to PHP Unit Functional tests are failing
Fail Other phpunit-38.xml 0 Drupal\Tests\block_content\Function
PHPUnit Test failed to complete; Error: PHPUnit 10.5.38 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.14
Configuration: /builds/issue/drupal-3250234/core/phpunit.xml.dist
---- Drupal\Tests\system\Functional\System\ThemeTest ----
Status Group Filename Line Function
--------------------------------------------------------------------------------
Fail Other phpunit-17.xml 0 Drupal\Tests\system\Functional\Syst
PHPUnit Test failed to complete; Error: PHPUnit 10.5.38 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.14
Configuration: /builds/issue/drupal-3250234/core/phpunit.xml.dist
---- Drupal\Tests\olivero\Functional\NodeTitleTest ----
Status Group Filename Line Function
--------------------------------------------------------------------------------
Fail Other phpunit-67.xml 0 Drupal\Tests\olivero\Functional\Nod
PHPUnit Test failed to complete; Error: PHPUnit 10.5.38 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.14
Configuration: /builds/issue/drupal-3250234/core/phpunit.xml.dist
ahsannazir → changed the visibility of the branch 3490443-action-btn-margin to active.
The MR #10438 seems similar to existing MR #10432. I have updated MR#10432 with latest changes from 11.x.
It is advised to not create duplicate MRs
The issue you're describing is a common usability problem in UI design. This is due to the Sticky action button location. The sticky action button is positioned in the upper-right corner of the interface. The user menu s positioned near to the sticky action button. So users often move their mouse quickly to the corner to click the button. As the result, If the cursor overshoots the sticky action button, it triggers the user menu dropdown, which then obstructs the button.
The possible solutions or suggestions i can think of is " Increase the Distance Between the Sticky Button and User Menu".
ahsannazir → made their first commit to this issue’s fork.
i am not able to reproduce the issue.
Can you please update this issue with more detailed steps to reproduce and screenshots.
i have the verified the MR changes and are working fine as expected. Attaching screen capture for reference.
Created a MR as per #15
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
I have overriden the is-active styles.
Before:
After:
ahsannazir → made their first commit to this issue’s fork.
The changes in MR #127 are applied successfully.
Now, the slogan is visible in all the cases:
Show slogan only
Show slogan and name
Show slogan and logo
Show slogan with name and logo
@marc.bau I have followed the steps mentioned in #14 but was not able to reproduce it.
Could you please add a screen capture to see what exactly looks broken
@gauravvvv Can you please add/update the issue summary with proposed solution
Issue 1: Not reproducible on Drupal 11.x.
Issue 2: There is margin-top: 0.9375rem on .js .field--widget-paragraphs .draggable .tabledrag-handle::after coming from paragraphs.widget.css
Issue 3: /admin/config/development/features shows The requested page could not be found.. Need more details
Removed the display:grid styles from .view, .view-content.
Kristen Pol → credited ahsannazir → .
The tranisition is working as expected but in chrome i had turn settings on at:
chrome://flags#view-transition
chrome://flags#view-transition-on-navigation
This issue no longer exists as we don't see any radio buttons now when we insert a image in the body of the content block.
Not able to reproduce the issue at my end. Can you please add the detailed steps to reproduce the issue.
There is max-width set for page-wrapper. We might need to align it to center after the max-width exceeds.
ahsannazir → made their first commit to this issue’s fork.
I believe 9px was used because same value has been used on
dropbutton a
. I checked the multiple breakpoints and i see that padding is same across all breakpoints similar to the
dropbutton a
I have tested the issue, the errors in the console are fixed. Attaching Before and After
Before:
After:
ahsannazir → changed the visibility of the branch 3250234-add-the-functionality to hidden.
@mherchel . I will move my branch to hidden. I'll review the MR and see what can i do to move it furhter. Thanks!
nod_ → credited ahsannazir → .
ahsannazir → made their first commit to this issue’s fork.
I am not able to reproduce the issue. Attaching screenshots for reference
@finnsky, This makes sense and the above/inline field display is working as expected.
Inline:
Above:
The styles are looking as expected. Only thing i can figure out is the flex direction is column now. Attaching screenshot below
@sanket.tale The double status messages get printed on the page when you have try to add/remove blocks
ahsannazir → changed the visibility of the branch 11.x to hidden.
The SVG code has been removed from twig file and SVG has been moved to images/src folder.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
The close btn is keyboard accessible now and also verified pressing the Esc key closes the menu.
@riddhi.addweb Can you please follow the Steps to reproduce once again. i am able to see slogan . attaching screenshot
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
ahsannazir → made their first commit to this issue’s fork.
@finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?
The Meta component is looking as expected.
Created MR from patch given in #6
ahsannazir → made their first commit to this issue’s fork.
@SystemLord Can you please add Screenshot or screen recording to help identify the issue
The labels are getting fixed in
https://www.drupal.org/project/drupal/issues/3446433
🐛
Navigation: Theme aside layout builder section on navigation block page
Needs work
. Lets wait for it to be fixed first.
Attaching screenshot what it should like after above issue gets fixed
The layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|
i could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
Attaching screenshot how it looks with font-size of 1rem.
Created MR from #71
ahsannazir → made their first commit to this issue’s fork.
The hover styles on submenu child items are not as per the design shared above. Attaching sccreencapture
The font size is smaller now. Attaching screenshot for ref