🇮🇳India @ehsann_95

Account created on 19 April 2016, over 8 years ago
  • Frontend Engineer at QED42 
#

Recent comments

🇮🇳India ehsann_95

@marc.bau I have followed the steps mentioned in #14 but was not able to reproduce it.
Could you please add a screen capture to see what exactly looks broken

🇮🇳India ehsann_95

@gauravvvv Can you please add/update the issue summary with proposed solution

🇮🇳India ehsann_95

Issue 1: Not reproducible on Drupal 11.x.
Issue 2: There is margin-top: 0.9375rem on .js .field--widget-paragraphs .draggable .tabledrag-handle::after coming from paragraphs.widget.css
Issue 3: /admin/config/development/features shows The requested page could not be found.. Need more details

🇮🇳India ehsann_95

Removed the display:grid styles from .view, .view-content.

🇮🇳India ehsann_95

The tranisition is working as expected but in chrome i had turn settings on at:

chrome://flags#view-transition
chrome://flags#view-transition-on-navigation

🇮🇳India ehsann_95

This issue no longer exists as we don't see any radio buttons now when we insert a image in the body of the content block.

🇮🇳India ehsann_95

Not able to reproduce the issue at my end. Can you please add the detailed steps to reproduce the issue.

🇮🇳India ehsann_95

There is max-width set for page-wrapper. We might need to align it to center after the max-width exceeds.

🇮🇳India ehsann_95

I believe 9px was used because same value has been used on

dropbutton a

. I checked the multiple breakpoints and i see that padding is same across all breakpoints similar to the

dropbutton a
🇮🇳India ehsann_95

I have tested the issue, the errors in the console are fixed. Attaching Before and After

Before:

After:

🇮🇳India ehsann_95

ahsannazir changed the visibility of the branch 3250234-add-the-functionality to hidden.

🇮🇳India ehsann_95

@mherchel . I will move my branch to hidden. I'll review the MR and see what can i do to move it furhter. Thanks!

🇮🇳India ehsann_95

I am not able to reproduce the issue. Attaching screenshots for reference

🇮🇳India ehsann_95

@finnsky, This makes sense and the above/inline field display is working as expected.

Inline:

Above:

🇮🇳India ehsann_95

The styles are looking as expected. Only thing i can figure out is the flex direction is column now. Attaching screenshot below

🇮🇳India ehsann_95

@sanket.tale The double status messages get printed on the page when you have try to add/remove blocks

🇮🇳India ehsann_95

The SVG code has been removed from twig file and SVG has been moved to images/src folder.

🇮🇳India ehsann_95

The close btn is keyboard accessible now and also verified pressing the Esc key closes the menu.

🇮🇳India ehsann_95

@riddhi.addweb Can you please follow the Steps to reproduce once again. i am able to see slogan . attaching screenshot

🇮🇳India ehsann_95

@finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?

🇮🇳India ehsann_95

Created MR from patch given in #6

🇮🇳India ehsann_95

ahsannazir made their first commit to this issue’s fork.

🇮🇳India ehsann_95

@SystemLord Can you please add Screenshot or screen recording to help identify the issue

🇮🇳India ehsann_95

The labels are getting fixed in https://www.drupal.org/project/drupal/issues/3446433 🐛 Navigation: Theme aside layout builder section on navigation block page Needs work . Lets wait for it to be fixed first.
Attaching screenshot what it should like after above issue gets fixed

🇮🇳India ehsann_95

The layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|

🇮🇳India ehsann_95

i could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
Attaching screenshot how it looks with font-size of 1rem.

🇮🇳India ehsann_95

ahsannazir made their first commit to this issue’s fork.

🇮🇳India ehsann_95

The hover styles on submenu child items are not as per the design shared above. Attaching sccreencapture

🇮🇳India ehsann_95

The font size is smaller now. Attaching screenshot for ref

🇮🇳India ehsann_95

This only happens when the vertical scroll bar appears. The rest of icons are not center aligned when the scroll appears. Not sure what should be done to solve this case.

🇮🇳India ehsann_95

The SDC component for meta is working as expected. Attaching screenshot for reference.

🇮🇳India ehsann_95

Resetting/overriding the width works because the width set in layout.css for body.is-fixed .container is incorrect for this case.

🇮🇳India ehsann_95

Changing vertical-align to top also changes alignment for small section fields. Check screenshot below

🇮🇳India ehsann_95

ahsannazir made their first commit to this issue’s fork.

🇮🇳India ehsann_95

It seems reseting width fixes the issue. Attaching screenshot for reference.

🇮🇳India ehsann_95

The shadow is shown both on Desktop & Mobile when data-detected-y-overflow="true"

The 2nd point mentioned in #32 about flickering needs to be investigated more and fixed accordingly.

🇮🇳India ehsann_95

Yes now i can see the tooltip. It also happens when you enable "Display title " checkbox for the existing blocks in navigation toolbar

🇮🇳India ehsann_95

ahsannazir changed the visibility of the branch 3438878-regression-the-drawer to hidden.

🇮🇳India ehsann_95

Not able to reproduce the issue . Attaching screen capture for reference.

🇮🇳India ehsann_95

The pipeline is still failing for the MR. Not sure why it is failing.

Drupal\Tests\file\Functional\DownloadTest::testPrivateFileTransferWithoutPageCache
    Correctly denied access to a file when file_test sets the header to -1.
    Failed asserting that 200 is identical to 403.
    
    /builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:138
    /builds/issue/drupal-3447942/core/modules/file/tests/src/Functional/DownloadTest.php:76
Production build 0.71.5 2024