- Issue created by @mherchel
- First commit to issue fork.
- last update
about 1 year ago Custom Commands Failed - @stevenspriggs opened merge request.
- Status changed to Needs review
about 1 year ago 9:03pm 7 June 2023 - Status changed to Needs work
about 1 year ago 10:38pm 7 June 2023 - ๐บ๐ธUnited States smustgrave
CC failure in the MR.
Tried testing though and after applying the MR and clearing cache I get this error
Twig\Error\LoaderError: Template "olivero:tags" is not defined in "core/themes/olivero/templates/field/field--node--field-tags.html.twig" at line 42. in Twig\Loader\ChainLoader->getCacheKey() (line 99 of vendor/twig/twig/src/Loader/ChainLoader.php).
- ๐จ๐ฆCanada Robert Ngo Montreal โ๏ธ
Robert Ngo โ made their first commit to this issueโs fork.
- last update
about 1 year ago Custom Commands Failed - @robert-ngo opened merge request.
- last update
about 1 year ago 29,426 pass, 6 fail - Assigned to Robert Ngo
- last update
about 1 year ago 29,427 pass, 5 fail - last update
about 1 year ago 29,427 pass, 5 fail - last update
about 1 year ago 29,427 pass, 5 fail - last update
about 1 year ago 29,427 pass, 5 fail - last update
about 1 year ago 29,427 pass, 5 fail - ๐บ๐ธUnited States mherchel Gainesville, FL, US
After a quick review, this is looking really good!
The only quick nit is that you can simplify your include function.
instead of doing a
{{ include('olivero:tags', { attributes: attributes, label_hidden: label_hidden,
you can simplify to
{{ include('olivero:tags', { attributes, label_hidden,
Also, I'm guessing that the tests are failing because SDC is not being enabled by default. So tests won't pass at this point
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 29,427 pass, 5 fail - last update
about 1 year ago 29,404 pass, 7 fail - ๐บ๐ธUnited States mherchel Gainesville, FL, US
This is looking just about perfect! The only major change is to assemble the classes and title_classes arrays within the
field--node--field-tags.html.twig
file.Note that tests will not pass on this because SDC is not a part of standard profile. Once this gets to a good place we'll postpone it until SDC becomes stable.
- last update
about 1 year ago 29,434 pass, 5 fail - Status changed to Needs review
about 1 year ago 7:30pm 14 June 2023 - Status changed to Postponed
about 1 year ago 11:19pm 14 June 2023 - ๐บ๐ธUnited States smustgrave
Changes look good (with my limited knowledge of SDC). I'm assuming the failures are due to SDC not being in standard. Postponing issue until that happens.
- Issue was unassigned.
- Status changed to Active
7 days ago 4:09pm 20 July 2024 - Status changed to Needs review
7 days ago 5:58pm 20 July 2024 - ๐ท๐ธSerbia finnsky
I started a new approach because I believe that styles in components should not be tied to Drupal. This makes them more flexible.
So it shouldn't be
.field .node-- and other thingsJust pure simple and clear css
Also fixed flexboxes and added support for label above
Please check!
- ๐ฎ๐ณIndia ehsann_95
The styles are looking as expected. Only thing i can figure out is the flex direction is column now. Attaching screenshot below
- ๐ฎ๐ณIndia ehsann_95
@finnsky, This makes sense and the above/inline field display is working as expected.
Inline:
Above: