Montreal ⚜️
Account created on 30 September 2009, over 14 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️
πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

Robert Ngo β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

We discovered a bug with the regex.
Only on Safari on iOS 15.x, the regex is not recognized correctly, causing all JS to failed.

The similar problem is discussed at https://github.com/twopluszero/next-images/issues/55#issuecomment-956545681
The solution is to use RegExp constructor, instead of using regular expression literal.

The following patch fixes this problem, tested on Safari iOS 15.x

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

In our case, we get this issue when trying to run automate testing (go to a page to execute a few actions) on a password protected environment.
I'll work on mocking the issue and write a test case about it.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

Test it more and actually the patch of #16 failed on the following cases:

- username starts with `@`, i.e. https://@blah:blahblahblah@drupal.org
- multiple `@`, i.e. https://asds:blahblah@@blah@drupal.org

The following patch handles these cases:

- https://asds:blahblah@@blah@drupal.org
- https://asds:blahblahblah!@drupal.org
- https://@asds:blahblahblah@drupal.org
- https://@@ds:Ben3v@@@@@a@@@drupal.org
- https://@@ds:Ben3v@@@@@!!!@a@@@drupal.org
- https://@@ds:Ben3v@*&^@@!!!@a@@@drupal.org

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

I've tested the patch #16 and it seems to work well in the following cases:

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

I run into the same issue.
The problem is be because `core/popperjs` has been deprecated.

[#3307518]

A quick fix is to use the CDN version of popperjs
Tested on Drupal core 10.x and Ckeditor 4.x

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

I've revised the fake-dependency URLs and added the case for external CSS.
It's ready to retest now.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

I tried a fix using `UrlHelper::isExternal()` to detect external JS.
Also, should we have a mirror issue for external CSS?

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

Robert Ngo β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

Robert Ngo β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

Revise patch, extending old URL validation method.

πŸ‡¨πŸ‡¦Canada Robert Ngo Montreal ⚜️

This is not a Feeds problem but a Clientside validation problem.
In Drupal context, I think we should extend the URL validation to accept `public://` and `private://` scheme.

I proposed the fix on Clientside validation module following your suggestions

https://www.drupal.org/project/clientside_validation/issues/3356402 πŸ› URL validation to accept `public` and `private` urlscheme Fixed

Production build https://api.contrib.social 0.62.1