Navigation: Theme aside layout builder section on navigation block page

Created on 10 May 2024, 4 months ago
Updated 9 August 2024, 30 days ago

Problem/Motivation

Layout builder region on Navigation block page is breaking when collapsed.

Steps to reproduce

1. Install navigation module.
2. Go on admin/config/user-interface/navigation-block/ page
3. Collapse the left side bar
4. You'll see the design is breaking.
5. See image for reference

Proposed resolution

Fix the styling of collapsed aside region.

Solution - I have fixed the font size and reduced the padding on nav.

Remaining tasks

User interface changes

After Fix -

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs review

Version

11.0 🔥

Component
Navigation 

Last updated 1 day ago

No maintainer
Created by

🇮🇳India Gauravvv Delhi, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Gauravvv
  • Hi @Gauravvvv Could you please provide any styling recommendations? Here's how I styled it and will modify it if necessary.

  • 🇮🇳India ehsann_95

    i could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
    Attaching screenshot how it looks with font-size of 1rem.

  • Merge request !86023446433: Navigation theme aside styling → (Open) created by sanket.tale
  • Pipeline finished with Failed
    2 months ago
    Total: 218s
    #212802
  • Hi, Created MR for the issue please review it. Thanks!

  • Status changed to Needs review 2 months ago
  • Pipeline finished with Failed
    2 months ago
    Total: 4126s
    #212813
  • Pipeline finished with Failed
    2 months ago
    Total: 211s
    #212861
  • Pipeline finished with Success
    2 months ago
    Total: 633s
    #212867
  • Status changed to Needs work 2 months ago
  • 🇺🇸United States smustgrave

    Issue summary should be updated to include the solution and after screenshots.

    Don't need a code snippet but what was actually fixed.

  • 🇮🇳India ehsann_95

    The layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|

  • Status changed to Needs review 2 months ago
  • 🇮🇳India Kanchan Bhogade

    I've tested MR 8602 on Drupal 11.x
    MR is applied cleanly...

    Testing steps:
    1. Install the navigation module.
    2. Go to admin/config/user-interface/navigation-block/ page
    3. Collapse the left sidebar
    4. You'll see the design is breaking.
    5. Appy MR and check for the same

    Test Result:
    The layout builder section is fixed in the collapsed state and visually looks good.
    Attaching SS for reference
    RTBC+1

    Keeping "needs review" for code verification

  • Pipeline finished with Success
    2 months ago
    Total: 511s
    #214468
  • Status changed to Needs work 2 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    The navigation sidebar typically has icons:

    it seems like the issue reporter and everyone working on this issue are getting a version of the sidebar that is providing the alt text instead of the icons. This is not something I'm able to reproduce, but considering multiple contributors are seeing the exact same thing, I have to assume there are fairly straightforward steps beyond those in the issue summary to and this should be documented. I'm also not sure how to get it where layout builder can be used on a navigation block as seen in the screenshots, so that would be good to include in the issue summary as well.

    If the icons aren't showing up, there are already problems happening and making this look nicer isn't bad but probably not a major priority. We should ensure nothing in this MR conflicts with the correctly-loading Navigation bar.

  • 🇷🇸Serbia finnsky

    Imo simplest option here will be always expanded sidebar on that page(on desktop). ignoring user setting.

  • 🇮🇳India ehsann_95

    @finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?

  • 🇳🇿New Zealand quietone New Zealand

    Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

  • Status changed to Needs review about 1 month ago
  • Status changed to Needs work about 1 month ago
  • 🇷🇸Serbia finnsky

    Added 2 comments.

  • Pipeline finished with Success
    about 1 month ago
    Total: 550s
    #244315
  • Pipeline finished with Success
    about 1 month ago
    Total: 1394s
    #245237
  • Pipeline finished with Success
    about 1 month ago
    Total: 457s
    #245276
  • Status changed to Needs review 30 days ago
Production build 0.71.5 2024