- Issue created by @Gauravvv
Hi @Gauravvvv Could you please provide any styling recommendations? Here's how I styled it and will modify it if necessary.
- 🇮🇳India ehsann_95
i could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
Attaching screenshot how it looks with font-size of 1rem. - Status changed to Needs review
2 months ago 10:10am 1 July 2024 - Status changed to Needs work
2 months ago 1:17pm 1 July 2024 - 🇺🇸United States smustgrave
Issue summary should be updated to include the solution and after screenshots.
Don't need a code snippet but what was actually fixed.
- 🇮🇳India ehsann_95
The layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|
- Status changed to Needs review
2 months ago 6:05am 2 July 2024 - 🇮🇳India Kanchan Bhogade
I've tested MR 8602 on Drupal 11.x
MR is applied cleanly...Testing steps:
1. Install the navigation module.
2. Go to admin/config/user-interface/navigation-block/ page
3. Collapse the left sidebar
4. You'll see the design is breaking.
5. Appy MR and check for the sameTest Result:
The layout builder section is fixed in the collapsed state and visually looks good.
Attaching SS for reference
RTBC+1Keeping "needs review" for code verification
- Status changed to Needs work
2 months ago 1:56pm 3 July 2024 - 🇺🇸United States bnjmnm Ann Arbor, MI
The navigation sidebar typically has icons:
it seems like the issue reporter and everyone working on this issue are getting a version of the sidebar that is providing the alt text instead of the icons. This is not something I'm able to reproduce, but considering multiple contributors are seeing the exact same thing, I have to assume there are fairly straightforward steps beyond those in the issue summary to and this should be documented. I'm also not sure how to get it where layout builder can be used on a navigation block as seen in the screenshots, so that would be good to include in the issue summary as well.
If the icons aren't showing up, there are already problems happening and making this look nicer isn't bad but probably not a major priority. We should ensure nothing in this MR conflicts with the correctly-loading Navigation bar.
- 🇷🇸Serbia finnsky
Imo simplest option here will be always expanded sidebar on that page(on desktop). ignoring user setting.
- 🇮🇳India ehsann_95
@finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?
- 🇳🇿New Zealand quietone New Zealand
Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- Status changed to Needs review
about 1 month ago 4:12am 1 August 2024 - Status changed to Needs work
about 1 month ago 9:43am 2 August 2024 - Status changed to Needs review
30 days ago 6:35am 9 August 2024