- Issue created by @mherchel
- Assigned to xenophyle
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 1:17am 11 June 2023 - 🇺🇸United States mherchel Gainesville, FL, US
Thanks for all of the work on this! Initial review below:
-
+++ b/core/themes/olivero/components/pager/pager.components.yml @@ -0,0 +1,21 @@ +$schema: https://git.drupalcode.org/project/sdc/-/raw/1.x/src/metadata.schema.json
Lets get rid of the schema, status, and group keys here.
-
+++ b/core/themes/olivero/components/pager/pager.components.yml @@ -0,0 +1,21 @@ +slots:
There's no pager block, so this is not needed
-
+++ b/core/themes/olivero/components/pager/pager.twig @@ -0,0 +1,129 @@ +#}
Lets keep these comments within the pager.html.twig
-
+++ b/core/themes/olivero/components/pager/pager.twig @@ -0,0 +1,129 @@ + {% if items %} ... + {{ current == key ? 'Current page'|t : 'Page'|t }}
Need to use spaces not tabs.
-
+++ b/core/themes/olivero/components/pager/pager.twig @@ -0,0 +1,129 @@ + {% include "@olivero/../images/pager-previous.svg" %}
Lets 1) convert this to a twig function, and 2) bring all of the pager's images into the component and reference them using componentMetadata.
-
+++ b/core/themes/olivero/components/pager/pager.twig @@ -0,0 +1,129 @@ + </span>
Need to use spaces not tabs.
-
+++ b/core/themes/olivero/templates/navigation/pager.html.twig @@ -30,90 +30,12 @@ +{% embed "olivero:pager" with {
Since we're not using any blocks here, let's use an include function.
-
- Status changed to Needs review
over 1 year ago 3:00am 17 August 2023 - last update
over 1 year ago Custom Commands Failed - 🇮🇳India gauravvvv Delhi, India
Addressed feedbacks from #6, attached interdiff for same. please review
- Status changed to Needs work
over 1 year ago 2:42pm 20 August 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
over 1 year ago Build Successful - First commit to issue fork.
- Status changed to Needs review
5 months ago 6:26am 17 July 2024 - Status changed to RTBC
5 months ago 10:24am 17 July 2024 - 🇮🇳India Vishal Choudhary Dharmshala
In this scenario, I have created two nodes and a view to show a node using a pager.
After saving the view go to the page URL and show the Output like that
Screenshot Attached:To See this Output May be Moved to RTBC
Thanks. - Status changed to Needs work
5 months ago 12:08pm 17 July 2024 - 🇬🇧United Kingdom catch
Looks like the library definition still needs updating too.
- Status changed to Needs review
5 months ago 5:07am 22 July 2024 - Status changed to Needs work
5 months ago 2:48pm 22 July 2024