- Issue created by @djsagar
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 6:10am 19 January 2024 - Status changed to RTBC
over 1 year ago 12:42pm 19 January 2024 - 🇮🇳India divya.sejekan
Reviewed using MR! 366 #4 . The issue is resolved. Issues resolved for both Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default)
Testing Steps
Install the theme set as an administration theme.
Install the Workspaces module
Go to the /admin/appearance/settings/gin
Go to Navigation (Drupal Toolbar) choose Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default) and save.
Scroll top right-hand side and hover toolbar item which is left or right with the workspaces option
Now you are able to find this issueMoving to RTBC++
- Status changed to Needs work
4 months ago 12:28pm 18 December 2024 - 🇨🇭Switzerland saschaeggi Zurich
If this still applies, this MR needs a re-roll
- 🇮🇳India Kanchan Bhogade
Hi
I have tested MR 366 on Drupal 11.x
The MR is applied successfully
The overlapping issue is resolved for both Horizontal, Modern Toolbar or Sidebar, Vertical ToolbarTesting Steps:
I- nstall the theme set as an administration theme.
- Install the Workspaces module
- Go to the /admin/appearance/settings/gin
- Go to Navigation (Drupal Toolbar) choose Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default) and save.
- Scroll to the top right-hand side and hover the toolbar item which is left or right with the workspaces option
- Now you are able to find this issue
- Apply MR and check for the same
Attaching screenshots and recoding for reference
RTBC+1
- 🇩🇪Germany jurgenhaas Gottmadingen
I can confirm, this MR fixes this current issue. But I'm not sure about any unintended side-effects as the margin has been introduced for a reason. Most likely to make sure that the gaps between the toolbar items are equal and that was the case before this change. But we never had a coloured item right next to it, which then gets the border overlap on an expended shortcut item.
On the other hand, gaps between the items are not equal between all items, especially from contrib, already. So, that goal is probably unachievable?