Toolbar shortcut menu item overlapping with Workspaces option.

Created on 18 January 2024, over 1 year ago
Updated 19 January 2024, over 1 year ago

Problem/Motivation

Toolbar shortcut menu item overlapping with Workspaces option

Steps to reproduce

  1. Install the theme set as an administration theme.
  2. Install the Workspaces module
  3. Go to the /admin/appearance/settings/gin
  4. Go to Navigation (Drupal Toolbar) choose Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default) and save.
  5. Scroll top right hand side and hover toolbar item which is left or right with workspaces option
  6. Now your are able to find this issue

For reference:-

Proposed resolution

You can remove margin left which is coming in code.

[dir="ltr"] .gin-secondary-toolbar .toolbar-secondary .toolbar-bar .toolbar-tab {
    margin-left: -0.25em;
}

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇮🇳India djsagar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @djsagar
  • First commit to issue fork.
  • Merge request !366gin-3415526-remove margi-left. → (Open) created by Unnamed author
  • Pipeline finished with Success
    over 1 year ago
    Total: 376s
    #79671
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India ahsannazir

    Raised MR to remove margin left.

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India divya.sejekan

    Reviewed using MR! 366 #4 . The issue is resolved. Issues resolved for both Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default)

    Testing Steps
    Install the theme set as an administration theme.
    Install the Workspaces module
    Go to the /admin/appearance/settings/gin
    Go to Navigation (Drupal Toolbar) choose Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default) and save.
    Scroll top right-hand side and hover toolbar item which is left or right with the workspaces option
    Now you are able to find this issue

    Moving to RTBC++

  • Pipeline finished with Failed
    6 months ago
    #310445
  • Pipeline finished with Success
    6 months ago
    Total: 669s
    #312338
  • Pipeline finished with Success
    6 months ago
    Total: 458s
    #312670
  • Pipeline finished with Success
    6 months ago
    Total: 993s
    #312810
  • Pipeline finished with Success
    6 months ago
    Total: 566s
    #314078
  • Pipeline finished with Success
    6 months ago
    Total: 477s
    #317037
  • Pipeline finished with Failed
    6 months ago
    Total: 440s
    #317045
  • Pipeline finished with Failed
    6 months ago
    Total: 478s
    #317050
  • Pipeline finished with Canceled
    6 months ago
    Total: 627s
    #317096
  • Pipeline finished with Success
    6 months ago
    Total: 564s
    #317101
  • Status changed to Needs work 4 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    If this still applies, this MR needs a re-roll

  • Pipeline finished with Failed
    4 months ago
    Total: 218s
    #374688
  • Pipeline finished with Success
    4 months ago
    Total: 248s
    #376783
  • 🇮🇳India Kanchan Bhogade

    Hi
    I have tested MR 366 on Drupal 11.x
    The MR is applied successfully
    The overlapping issue is resolved for both Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar

    Testing Steps:
    I

    1. nstall the theme set as an administration theme.
    2. Install the Workspaces module
    3. Go to the /admin/appearance/settings/gin
    4. Go to Navigation (Drupal Toolbar) choose Horizontal, Modern Toolbar or Sidebar, Vertical Toolbar (Default) and save.
    5. Scroll to the top right-hand side and hover the toolbar item which is left or right with the workspaces option
    6. Now you are able to find this issue
    7. Apply MR and check for the same

    Attaching screenshots and recoding for reference

    RTBC+1

  • 🇩🇪Germany jurgenhaas Gottmadingen

    I can confirm, this MR fixes this current issue. But I'm not sure about any unintended side-effects as the margin has been introduced for a reason. Most likely to make sure that the gaps between the toolbar items are equal and that was the case before this change. But we never had a coloured item right next to it, which then gets the border overlap on an expended shortcut item.

    On the other hand, gaps between the items are not equal between all items, especially from contrib, already. So, that goal is probably unachievable?

Production build 0.71.5 2024