JS errors from Drupal.behaviors.activeLinks (... is not a valid selector)

I have tested the issue, the errors in the console are fixed. Attaching Before and After

Before:

After:

Not sure the JS test is failing as expected. Test-only feature showed green.

#5, it is, but I force pushed then kind of screwed things up trying to manually run things on gitlab I think...
How can we relaunch it? Thanks

Moving back to needs review... The test fails correctly...
It doesn't look like this "Test-only" pipeline even starts/works

Oh I just realized now which job you meant, I focused on the wrong one.
https://git.drupalcode.org/issue/drupal-3464340/-/jobs/2320491
This should fail so something is odd indeed, back to needs work.

The "Test-only changes" pipeline was broken, should be fixed now with 🐛 Test-only job cannot be run due to wrong dependency Fixed .
I rebased the branch, it should work as expected now but I don't have the rights to run it it seems.

May have to be ran locally as the pipeline is showing as skipped

1) Drupal\Tests\system\FunctionalJavascript\ActiveLinkTest::testQueryStringQuotes
Error: Failed to execute 'querySelectorAll' on 'Document': '[data-drupal-link-system-path="user/2"]:not([hreflang])[data-drupal-link-query='{"check_logged_in":"1","foo":"'"}'],[data-drupal-link-system-path="user/2"][hreflang="en"][data-drupal-link-query='{"check_logged_in":"1","foo":"'"}']' is not a valid selector.

Ran locally and believe this is the correct error to receive so would say test coverage is there.

Manually testing the issue does appear resolved

Believe this one is good to go.

Should we be using CSS.escape instead of a custom regex? https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape_static

#12, yes you're right, we should.
I just tested with all kind of chars and CSS.escape handles everything, the regex replace doesn't and only handles ' (there are more chars to escape).

Never knew about CSS.escape but glad I do now!

question in MR

we can add back the queryString variable, shoving everything in the string is not very nice to read

whoops, forgot to move back to review, thanks

Feedback appears to be addressed.

nod_ → closed merge request !8963

Committed and pushed 91cd1ab5e49 to 11.x and 6f437449b19 to 10.4.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.