Olivero: Convert node metadata into a single directory component

FYI should avoid assigning tickets to yourself unless you're a maintainer
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →

Should just leave a comment you'll be working on it

Seems this MR is causing failures.

This is failing coding standards. There's also a lot of unrelated whitespace changes that should not be made here.

Hello all!

Pushed new MR with different approach.

We write components to make them reusable not only in node or node--teaser.
It should be encapsulated component which can appear in paragraphs, cards wherever.

It keeps all inner css inside. Its external geometry still controlled by `.node__meta` css class.
https://en.bem.info/methodology/css/#external-geometry-and-positioning

Please review!
Thanks

To see if this passes tests you can include sdc as an olivero dependency.

Just FYI until SDC is marked stable it can't be merged to olivero so these tickets for olivero and sdc will ultimately be postponed until that. But it's good to have them ready :)

@smustgrave
Yep. I know. Just want to to understand how it should/may look like in future.

@manojkumar_97 why you removed component? :)

Rebased. but work still needed here.

Some random test failures happens.

smustgrave → changed the visibility of the branch 3365377-olivero-convert-node to hidden.

Have not yet reviewed but see latest MR has a number of test failures.

The test failures are due to this error:

Drupal\Core\Render\Component\Exception\InvalidComponentException: [avatar] NULL value found, but an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).

Caused by the fact that the `author_picture` variable in the node template file is sometimes set, and sometimes not. For example if the feature is disabled in the theme, or if the user has no picture. This results in the `avatar` prop getting set to NULL, and the above error. The fix appears to be to not pass an `avatar` prop if we have no value for author_picture. I've added a commit that does that, though it's possible there are better approaches I couldn't figure out a way using Twig to conditionally set just one key in an object.

Let's see if there are any more failures after fixing that.

Mithun S → made their first commit to this issue’s fork.

Rebased the branch with latest changes from the target branch. The MR seems to be passing the test cases.
Please review the MR. Changing the status to Needs Review.
Thank you!

The SDC component for meta is working as expected. Attaching screenshot for reference.

Left some comments in the MR.

Gonna check

The Meta component is looking as expected.

Tried revisiting this one but still have concerns about the missing/changing class names.

@shweta__sharma if tagging for issue summary update mind leaving a comment also.

I think this needs a rebase as nightwatch keeps failing (re-ran twice)

rebased

finnsky → changed the visibility of the branch 3365377-metadata to hidden.

finnsky → changed the visibility of the branch 3365377-metadata to active.

Rebase seems good. I did a standard install on 11.x and verified the meta data appears unchanged.

Still a little iffy about the class changes but won't hold the issue up over it.

Would like pdureau to check this

pdureau → changed the visibility of the branch 3365377-metadata to hidden.

Mandatory fixes

Slots are not typed

So let's remove the type: object here:

  metadata:
    title: Metadata
    description: Additional metadata
    type: object

Consistent slot notation

The 2 slots have different notations, one with a block and a print node, one with only a block:

{% block avatar %}{{ avatar }}{% endblock %}
{% block metadata %}{% endblock %}

It is better to stay consistent. My personal preference would be no blocks (see: 🌱 Clarify SDC documentation by toning down Twig blocks promotion Active ), but if there is a block I would advise to add also the print node.

A summary (without the only and with_context keywords, for clarity):

Deprecated Twig filter: `spaceless`

The spaceless filter is deprecated as of Twig 3.12. While not a full replacement, you can check the whitespace control features.

Other feedbacks

As always, the attributes prop declaration is not necessary because automatically added to all components, but it doesn't hurt to add it so keep if you want:

    attributes:
      title: Attributes
      description: Meta attributes.
      type: Drupal\Core\Template\Attribute

In attributes and author_attributes, using a PHP Namespace as a prop type is not JSON schema valid and is skipping the SDC validator. However, describing an Attribute object with JSON Schema is complex without a reference resolver, so we can let it like that for now.