Fixed some of the issues related to pipeline and added a commit for the same MR. Still some of the tests are getting failed, keeping the issue status as unchanged.
Thanks!!.
Mithun S → made their first commit to this issue’s fork.
Reviewed out the various scenarios for the issue.
1. Without MR being applied and without navigation enabled.
2. Without MR being applied and with navigation enabled.
3. With MR and without navigation enabled.
With MR and with navigation enabled.
The MR looks good, the width for the container needs to be overwritten and after MR the issue seems to be resolving.
Attaching the different screenshots for the same. RTBC +1
Thank you.
Rebased the branch with latest changes from the target branch. The MR seems to be passing the test cases.
Please review the MR. Changing the status to Needs Review.
Thank you!
Added a rebase of the latest changes from the branch.
The MR looks mergable now. Thank you!
Mithun S → made their first commit to this issue’s fork.
Currently #00389a is used as (-admin-toolbar-color-blue-650) and #002566 is used as ( --admin-toolbar-color-blue-700). Hence introduced a new variable (--admin-toolbar-color-blue-670) for #002e9a and used the variables on css files. Please suggest if the variable name is good. If any changes that would be required, am happy to update the same.
Thank you!
Mithun S → made their first commit to this issue’s fork.
As the #experience-builder slack channel is recently opened. Added the channel name (#experience-builder) under the heading ( Many modules and themes have their own channels - for example ).
Mithun S → made their first commit to this issue’s fork.
Raised the PR against 11.x and updated the PR with changes. Please review.
Removed the pending .js class from the css files and added a commit. Please review.
Currently looking into this.
Mithun S → made their first commit to this issue’s fork.
Created a MR for the issue out of the patch. Please review.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Resolved the merge conflicts and added a rebase for the MR. Please review.
Mithun S → made their first commit to this issue’s fork.
Pushed a rebase from the 11.x branch. Please review
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Updating the issue summary for the issue.
Mithun S → changed the visibility of the branch 2421365-merge-node.css-files to hidden.
Mithun S → made their first commit to this issue’s fork.
Pushed a rebase for the PR and now the test failures are passed.
Mithun S → made their first commit to this issue’s fork.
Resolved the Linting issue appearing on MR.
Mithun S → made their first commit to this issue’s fork.
I have validated before MR that the slogan is not displaying on the UI for olivero theme.
Validated by switching to the branch and verified the slogan is visible/hidden as per the users choice and based on the block configuration. Attaching the screenshots for reference.
RTBC +1.
Thought of a different approach without changing the global css. Decreased the z-index value of the table header based on the content page so that the autocomplete dropdown doesn't hide behind it. Also checked the table header remains sticky on the content pages.
Please review.
Mithun S → changed the visibility of the branch 3444344-claro-Autocomplete-dropdown to hidden.
Mithun S → made their first commit to this issue’s fork.
Added a rebase and resolved the merge conflicts. Please review.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Added a rebase for the PR which was raised.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Mithun S → changed the visibility of the branch 3438895-add-the-new to hidden.
lauriii → credited Mithun S → .
Observed that all the strong tags in the files are removed, the css of bold for the error message is missing for 11.x. Added the required css and raised a new PR against 11.x branch. Please review.
Mithun S → made their first commit to this issue’s fork.
I have checkout to the branch and reviewed the functionality on the View Enable/Disable from the view page. The functionality looks good to me. After enabling the view from view page the view is listed under Enable section and the background color of the view changes to white. Attaching the screenshots of the same. Thank you!!
RTBC +1
Mithun S → made their first commit to this issue’s fork.
Validated the missing css and added it to the dialog.pcss.css file and compiled and pushed a commit to the branch.
Moving the issue to Needs review.
Mithun S → made their first commit to this issue’s fork.
Addressed all the review comments and pushed a commit. Changing the status to Needs review.
Thank you!
Changing the .tabs to .tabs__link will make the UI look like this ( screenshot: Tab-links-UI ) . Also the UI beaks on click of the tabs. This issue Needs more work.
Addressed the review comments and updated the PR. Changing the status to Needs review.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Fixed the Phpcs issues for the module and raised an MR to the branch 1.0.x
Changing the status of issue to Needs review.
Mithun S → made their first commit to this issue’s fork.
Add a MR for the above issue from the patch #2 as the MR's can be tracked better compared to legacy patch methods.
Thanks!
Mithun S → made their first commit to this issue’s fork.
Verified the changes with Drupal 10 and merged the New compatibility changes to a new branch 3.0.0 and will soon be released.
Marking the ticket as Fixed.
I have checkout to the branch and applied the changes on my local and reviewed the changes and the changes looks good. Leaving the column background color as white is a good option according to me. Attaching the screenshots of the disabled view.
RTBC +1
Working as expected. Marking the ticket as Closed as per the mentioned comment on #2 by the reporter.
Updated the original MR and fixed the Pipeline issue.
Mithun S → made their first commit to this issue’s fork.
Changes looks good. Since we are updating only the text on comments, I don't anticipate regression.
Thank you!
Hi @gaurav_manerkar. Could you please brief more about the steps to reproduce on the local instance ?
Thanks in advance!
Created a MR for the issue with the changes of above patch. Any further changes can be pushed to the same branch.
Thank you!
Mithun S → made their first commit to this issue’s fork.
Addressed one of the review comments on the PR and pushed a commit for the same. Thank you!
Removed the unnecessary trailing comma in the css files and updated the PR with a commit.
Mithun S → made their first commit to this issue’s fork.
Mithun S → made their first commit to this issue’s fork.
Changing the status to Needs work. Thank you!
Thanks again!!. The approach that is followed looks good to me. But I see there is a impact on the view edit form. The font size of the text Advanced got increased in the right sidebar and the PR has some impact on it. Could you please check ?
Note: Please donot change the font size of Advanced via css.
Thank you @ressa for working on this. But according to my view this should be handled from php instead of adding it via css. For an multilingual sites it is hard to handle the translations if the plain texts are added via css using content attributes.
Mithun S → made their first commit to this issue’s fork.
Mithun S → created an issue.
Mithun S → created an issue.
Reviewed the PR and observed the changes in the PR are breaking the user account menu. Attaching the screenshot for the reference.
Thanks!
Changing the status of the ticket as this issue is reviewed by a community member. The MR could be taken ahead if this issue needs to be resolved.
Thanks!
I retested the issue and can confirm that it has been resolved with the new update. Therefore, I am closing this issue.
Thank you @Harish for reviewing and updating about the issue.
Uploading a patch for the issue reported by overriding the value on the gin theme scss file. Please review the patch uploaded.
Mithun S → created an issue.
Reviewing the MR. Hence assigning the issue to myself.
Adding a new patch file based on the feedback on the ticket. Please review the updated patch on the issue.
Working on the feedbacks.
Reviewed the issue based on the MR8 raised and verified the region-content css is getting applied on the content pages. Attaching the screenshots for the same.
Reviewing the MR raised against this issue. Hence assigning the ticket to myself
I have installed the theme on a fresh setup and placed the main navigation block on the desired region. The menu items expands on the mobile view for me too.
Reviewing the patch. Hence assigning the issue to myself.