Stable 9 is trying to override non-existing css files.

I have updated the library overrides. Attached patch for same. please review

The last submitted patch, 2: 3393441-2.patch, failed testing. View results →

I have tested the attached patch from Gauravvvvv, and it worked for me

Mithun S → made their first commit to this issue’s fork.

Add a MR for the above issue from the patch #2 as the MR's can be tracked better compared to legacy patch methods.
Thanks!

Appears to have a test failure.

Setting to Needs review again, I just want to check that we don't have a red herring test failure.

===
Thanks to Code Enigma for sponsoring my time to work on this.

I think I've come back out of the rabbit hole and tracked down the correct issue here. It's not that stable9 is trying to reference the wrong files, stable9 does not have any CSS files any more for off_canvas, they were all removed by c2af57548.

So when we try to run the tests, specifically Stable9LibraryOverrideTest, it's looking for CSS files in stable9/css/core/dialog... which are no longer there.

Let's see if removing that section of the stable9.info.yml file and the corresponding library from $librariesToSkip fixes this issue.

===
Thanks to Code Enigma for sponsoring my time to work on this.

Nice research!

Still seems Stable9LibraryOverrideTest is failing, with you though thought removing 'core/drupal.dialog.off_canvas', from the skipped would be the fix.

Hi @smustgrave,

Looks like we need to keep the line to override the off_canvas library in the $librariesToOverride array.

Tests are passing now.

---
Thanks to Code Enigma for sponsoring my time to work on this.

Removal looks good to me.

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

catch → closed merge request !6841

Automatically closed - issue fixed for 2 weeks with no activity.