Hi
I had the same problem
Drupal 10.2 php 8.2
I had both the options "Enable scrolling for links that will trigger a page reload" and "Enable scrolling for in-page links" enabled on the settings page however, I created a fork by adjusting the href selector and it looks fine. I have tried with #section1 and with /node/52#section1 and it worked without problems
DavidMV97 → made their first commit to this issue’s fork.
patch #2 works fine in Drupal 10.2
The provided patch was successfully applied to my local Drupal 8.9 installation
The next fork fix the issue
DavidMV97 → made their first commit to this issue’s fork.
DavidMV97 → made their first commit to this issue’s fork.
DavidMV97 → made their first commit to this issue’s fork.
In the last change I pushed to the forked branch, I managed to get the redirection to work correctly in both Drupal 10 and Drupal 9. It is ready for review.
I have tried the proposed adjustment, and it worked well for me. I also thought it would be better to update the dependencies in the composer.json file of the module. I have pushed the changes to the branch for review.
DavidMV97 → made their first commit to this issue’s fork.
DavidMV97 → made their first commit to this issue’s fork.
The patch provided by @sidharth_soman worked well for me, attached screenshot
I added and obtained the repository from this issue fork, and the fix worked well for me
The fix worked correctly for me in Drupal 9.3.
Hello,
In the tests I have conducted on both Drupal 9.3 and Drupal 10.1, the provided patch has not worked for me
aldibier → credited DavidMV97 → .
I have tested the patch provided by @akshaya.kumar, and it applies without any errors, but the style changes are not reflected in the menu. I believe the changes in the main CSS file are missing, as the modification is currently only applied in the _header.scss file.
Hello,
I have tried the patch provided by @alok_singh, and it didn't work for me on Drupal version 10.1.6.
Hello,
I have tested the patch provided by @akshaya.kumar, and it applied successfully. However, the styles in the pagination are not being applied. Upon reviewing the changes in the patch, I noticed that there are only modifications in the _pages.scss file. Therefore, I believe the compiled styles might be missing, either in the global.css or media.css file within the css folder.
DavidMV97 → made their first commit to this issue’s fork.
DavidMV97 → made their first commit to this issue’s fork.
I was able to replicate the issue in both Drupal 10.1.6 and Drupal 9.5.0, but I couldn't successfully apply the provided patch in either of them.
DavidMV97 → made their first commit to this issue’s fork.
In my Drupal 8.9 version, I have been unable to apply the patch provided by @Harsh Panchal
By applying the patch provided by @Harsh Panchal, the 'core_version_requirement' property is correctly added. It worked for me on Drupal 8.9
Before applying the patch, I get this output:
FILE: /var/www/html/repos/video_embed_twitter/src/Plugin/video_embed_field/Provider/Twitter.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
7 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------------------
FILE: /var/www/html/repos/video_embed_twitter/tests/src/Unit/ProviderUrlParseTest.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
15 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------------------
FILE: /var/www/html/repos/video_embed_twitter/video_embed_twitter.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
But the patch provided by @Harsh Panchal worked well for me. Tested with Gitpod on Drupal version 9.5.11
I have tried the patch provided by @Aakansha, and it worked well for me.
I have applied the patch provided by @Chris Matthews, and it worked correctly
"I have applied the patch provided by Aakansha, and it worked for me.
I have applied the patch provided by Aakansha, and the form took the styles correctly.
I have tested the patch provided by Kritika_21, and it applies the styles correctly.
I conducted the respective tests on Drupal 10 and Drupal 9 to test the latest patch, but I couldn't replicate the error. Would it be possible to provide more details about the error for better replication?
As indicated by jrwest_webguy in comment #5, this issue has been identified as duplicate. Kindly visit https://www.drupal.org/project/2985855/issues/3402946 🐛 Menu controls displayed twice using Claro on Drupal 10.1.x Needs review for further details.
The patch provided by Yogesh Sahu works on Drupal 9.5 with PHP 8.1 and MariaDB 10.4
I have tested the attached patch from Gauravvvvv, and it worked for me
Hello everyone, I have conducted tests with the module without applying the patch published by kksandr, and I cannot identify the issue associated with this case. After applying the patch, I also don't see any errors. However, I consider it important to determine how to reproduce the issue in order to know if the problem has been resolved.