Menu controls displayed twice using Claro on Drupal 10.1.x

Created on 20 November 2023, 12 months ago
Updated 30 November 2023, 12 months ago

Problem/Motivation

I do not have this issue on Drupal v9.4.15, and I do not believe I had this issue with Drupal v10.0.x. May (or may not) have something to do with the new 'Menu Linkset' feature β†’ introduced with Drupal 10.1.x. See image.

Steps to reproduce

Upgrade Drupal to version 10.1.x.

πŸ› Bug report
Status

Needs review

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jrwest_webguy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jrwest_webguy
  • πŸ‡ΊπŸ‡ΈUnited States jrwest_webguy
  • πŸ‡ΊπŸ‡ΈUnited States jrwest_webguy

    It has to do with BigPipe module -- per this comment πŸ’¬ Drupal behaviors are added twice Closed: works as designed . To test, I disabled BigPipe, and only one menu settings option was presented by Drupal 10.1.x. Now I just have to figure out WHERE to implement the once function within the js files for this module, so BigPipe doesn't mess up the display.

  • Assigned to jrwest_webguy
  • Status changed to Needs review 12 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jrwest_webguy

    I never did figure out where to put the once directive, so I hacked a fix. I added code to check if BigPipe module was installed. If it is, the menu_parent_form_ui.js file tries to build a new variable but fails, this prevents the code from building the second, redundant, menu settings drop-down.

    I have tested this with Drupal v9.4.15 and Drupal v10.1.4, and it seems to work for both -- with and without BigPipe installed.

    The attached patch file supersedes all previous patch files I have uploaded.

  • I conducted the respective tests on Drupal 10 and Drupal 9 to test the latest patch, but I couldn't replicate the error. Would it be possible to provide more details about the error for better replication?

  • πŸ‡ΊπŸ‡ΈUnited States jrwest_webguy

    Duplication error only happens on Drupal 10.1.x WITH BigPipe module and this module enabled at the same time.

    My reference to testing with Drupal v9.4.15, was just to ensure there were no new issues created using this patch on Drupal below v10.1.x.

Production build 0.71.5 2024