DomPDF library vulnerability

Created on 18 December 2023, over 1 year ago

Hello. Could we please bump the dompdf library used by the module. See https://github.com/advisories/GHSA-ff5x-7qg5-vwf2

Patch attached.

Thanks

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom xiwar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @xiwar
  • 🇬🇧United Kingdom xiwar
  • The provided patch was successfully applied to my local Drupal 8.9 installation

  • Status changed to RTBC 12 months ago
  • 🇦🇷Argentina darktek

    I would like to use this patch but I'm wondering, what If I already have this module installed?
    I applied the patch but even if I execute composer update I don't get any new update in my files.
    Could someone help me please?

  • 🇨🇷Costa Rica maxmendez

    After testing on a fresh installation, I found that dompdf/dompdf (v2.0.8) was automatically downloaded when requiring drupal/pdf_generator:^2.0, as shown below:

    $ composer require 'drupal/pdf_generator:^2.0'
    ...
    - Locking dompdf/dompdf (v2.0.8)
    ...
    

    Considering this, the patch may not be strictly necessary, as updating dependencies seems sufficient to address the vulnerability. Reviewing the patch, it introduces minimal changes, so sites already using the module might only need to update their dependencies.

  • 🇦🇷Argentina darktek

    Even using this patch the module doesn't download the new dompdf library because the composer.lock file points out to the v2.0.
    The idea is to have the v3.0 to avoid current warnings when you execute a composer install command:

    Warning: Ambiguous class resolution, "FontLib\OpenType\File" was found in both "/var/www/html/vendor/dompdf/php-font-lib/src/FontLib/OpenType/File.php" and "/var/www/html/vendor/phenx/php-font-lib/src/FontLib/OpenType/File.php", the first will be used.

Production build 0.71.5 2024